Re: [PATCH 5/5] f2fs: use blk_plug in all the possible paths

2016-07-18 Thread Jaegeuk Kim
On Mon, Jul 18, 2016 at 08:59:52PM -0700, Christoph Hellwig wrote: > On Thu, Jul 14, 2016 at 08:05:02PM -0700, Jaegeuk Kim wrote: > > >From kernel guys working on android. > > Well, until it's mainline it simply doesn't matter, so NAK to this > patch. Tying power behavior to plugs also sounds pre

Re: [PATCH 5/5] f2fs: use blk_plug in all the possible paths

2016-07-18 Thread Christoph Hellwig
On Thu, Jul 14, 2016 at 08:05:02PM -0700, Jaegeuk Kim wrote: > >From kernel guys working on android. Well, until it's mainline it simply doesn't matter, so NAK to this patch. Tying power behavior to plugs also sounds pretty broken, so we'd probably come up with something better if they bothered t

Re: [PATCH 5/5] f2fs: use blk_plug in all the possible paths

2016-07-14 Thread Jaegeuk Kim
On Thu, Jul 14, 2016 at 07:21:32PM -0700, Christoph Hellwig wrote: > On Thu, Jul 14, 2016 at 05:46:29PM -0700, Jaegeuk Kim wrote: > > The main reason is that blk_start_plug can be used to wake up from low-power > > mode before submitting further bios. > > Where does that myth come from? >From ker

Re: [PATCH 5/5] f2fs: use blk_plug in all the possible paths

2016-07-14 Thread Christoph Hellwig
On Thu, Jul 14, 2016 at 05:46:29PM -0700, Jaegeuk Kim wrote: > The main reason is that blk_start_plug can be used to wake up from low-power > mode before submitting further bios. Where does that myth come from?

[PATCH 5/5] f2fs: use blk_plug in all the possible paths

2016-07-14 Thread Jaegeuk Kim
This patch reverts 19a5f5e2ef37 (f2fs: drop any block plugging), and adds blk_plug in write paths additionally. The main reason is that blk_start_plug can be used to wake up from low-power mode before submitting further bios. Signed-off-by: Jaegeuk Kim --- fs/f2fs/checkpoint.c | 7 +++ fs/f