Re: [PATCH 5/5] debugfs: remove goto in debugfs_remount()

2012/10/27 Greg KH : > On Sat, Oct 27, 2012 at 04:05:29PM +0800, Yan Hong wrote: >> Simple code clean to remove goto. > > There is nothing wrong with gotos on error paths, so this one should > stay. > > greg k-h I thought we use goto on error path because there is no other elegant ways to do the t

Re: [PATCH 5/5] debugfs: remove goto in debugfs_remount()

On Sat, Oct 27, 2012 at 04:05:29PM +0800, Yan Hong wrote: > Simple code clean to remove goto. There is nothing wrong with gotos on error paths, so this one should stay. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.k

[PATCH 5/5] debugfs: remove goto in debugfs_remount()

Simple code clean to remove goto. Signed-off-by: Yan Hong --- fs/debugfs/inode.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c index 58eadc1..c0b06a3 100644 --- a/fs/debugfs/inode.c +++ b/fs/debugfs/inode.c @@ -221,12 +221,11