OT / Pascal (was: [PATCH 40/79] link_path_walk: turn inner loop into explicit goto)

2015-05-14 Thread el_es
Linus Torvalds linux-foundation.org> writes: > > On Mon, May 4, 2015 at 10:22 PM, Al Viro zeniv.linux.org.uk> wrote: > > +l: > > This looked like noise. > > PLEASE. We're not programming in Pascal What is it with Pascal that every C-like programmer is bashing (uh oh..) it ? http://wiki.laz

Re: [PATCH 40/79] link_path_walk: turn inner loop into explicit goto

2015-05-05 Thread Al Viro
On Tue, May 05, 2015 at 08:09:04AM -0700, Linus Torvalds wrote: > On Mon, May 4, 2015 at 10:22 PM, Al Viro wrote: > > +l: > > This looked like noise. > > PLEASE. We're not programming in Pascal (and thank all Gods for that), > so we can have labels that have meaningful names. Also, we're not > a

Re: [PATCH 40/79] link_path_walk: turn inner loop into explicit goto

2015-05-05 Thread Linus Torvalds
On Tue, May 5, 2015 at 8:17 AM, Al Viro wrote: > > Something like this_used_to_be_the_beginning_of_loop_body? No, but at least "loop:" or "repeat:" or something. That "l:" really looked like a fly shat on my monitor. Linus -- To unsubscribe from this list: send the line "uns

Re: [PATCH 40/79] link_path_walk: turn inner loop into explicit goto

2015-05-05 Thread Linus Torvalds
On Mon, May 4, 2015 at 10:22 PM, Al Viro wrote: > +l: This looked like noise. PLEASE. We're not programming in Pascal (and thank all Gods for that), so we can have labels that have meaningful names. Also, we're not ashamed of using goto where it makes sense, so we don't need to try to hide the l

[PATCH 40/79] link_path_walk: turn inner loop into explicit goto

2015-05-04 Thread Al Viro
From: Al Viro Signed-off-by: Al Viro --- fs/namei.c | 61 - 1 file changed, 32 insertions(+), 29 deletions(-) diff --git a/fs/namei.c b/fs/namei.c index d6235ea..d46df22 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -1767,6 +1767,10 @@