Re: [PATCH 4.4 stable net] net: tcp: Fix use-after-free in tcp_write_xmit

2019-07-28 Thread maowenan
On 2019/7/27 19:40, Greg KH wrote: > On Sat, Jul 27, 2019 at 07:22:30PM +0800, maowenan wrote: >> >> >> On 2019/7/27 18:44, maowenan wrote: >>> >>> >>> On 2019/7/24 20:13, maowenan wrote: On 2019/7/24 19:05, Greg KH wrote: > On Wed, Jul 24, 2019 at 05:17:15PM +0800, Mao Wenan

Re: [PATCH 4.4 stable net] net: tcp: Fix use-after-free in tcp_write_xmit

2019-07-27 Thread Greg KH
On Sat, Jul 27, 2019 at 07:22:30PM +0800, maowenan wrote: > > > On 2019/7/27 18:44, maowenan wrote: > > > > > > On 2019/7/24 20:13, maowenan wrote: > >> > >> > >> On 2019/7/24 19:05, Greg KH wrote: > >>> On Wed, Jul 24, 2019 at 05:17:15PM +0800, Mao Wenan wrote: > There is one report about

Re: [PATCH 4.4 stable net] net: tcp: Fix use-after-free in tcp_write_xmit

2019-07-27 Thread maowenan
On 2019/7/27 18:44, maowenan wrote: > > > On 2019/7/24 20:13, maowenan wrote: >> >> >> On 2019/7/24 19:05, Greg KH wrote: >>> On Wed, Jul 24, 2019 at 05:17:15PM +0800, Mao Wenan wrote: There is one report about tcp_write_xmit use-after-free with version 4.4.136: BUG: KASAN

Re: [PATCH 4.4 stable net] net: tcp: Fix use-after-free in tcp_write_xmit

2019-07-27 Thread maowenan
On 2019/7/24 20:13, maowenan wrote: > > > On 2019/7/24 19:05, Greg KH wrote: >> On Wed, Jul 24, 2019 at 05:17:15PM +0800, Mao Wenan wrote: >>> There is one report about tcp_write_xmit use-after-free with version >>> 4.4.136: >>> >>> BUG: KASAN: use-after-free in tcp_skb_pcount include/net/tcp

Re: [PATCH 4.4 stable net] net: tcp: Fix use-after-free in tcp_write_xmit

2019-07-26 Thread maowenan
On 2019/7/25 14:19, Eric Dumazet wrote: > > > On 7/25/19 6:29 AM, maowenan wrote: >> > >> Syzkaller reproducer(): >> r0 = socket$packet(0x11, 0x3, 0x300) >> r1 = socket$inet_tcp(0x2, 0x1, 0x0) >> bind$inet(r1, &(0x7f000300)={0x2, 0x4e21, @multicast1}, 0x10) >> connect$

Re: [PATCH 4.4 stable net] net: tcp: Fix use-after-free in tcp_write_xmit

2019-07-24 Thread Eric Dumazet
On 7/25/19 6:29 AM, maowenan wrote: > > Syzkaller reproducer(): > r0 = socket$packet(0x11, 0x3, 0x300) > r1 = socket$inet_tcp(0x2, 0x1, 0x0) > bind$inet(r1, &(0x7f000300)={0x2, 0x4e21, @multicast1}, 0x10) > connect$inet(r1, &(0x7f000140)={0x2, 0x104e21, @loopbac

Re: [PATCH 4.4 stable net] net: tcp: Fix use-after-free in tcp_write_xmit

2019-07-24 Thread maowenan
On 2019/7/24 22:07, Eric Dumazet wrote: > > > On 7/24/19 12:46 PM, maowenan wrote: >> >> >> On 2019/7/24 17:45, Eric Dumazet wrote: >>> >>> >>> On 7/24/19 11:17 AM, Mao Wenan wrote: There is one report about tcp_write_xmit use-after-free with version 4.4.136: BUG: KASAN: u

Re: [PATCH 4.4 stable net] net: tcp: Fix use-after-free in tcp_write_xmit

2019-07-24 Thread maowenan
On 2019/7/24 18:13, Eric Dumazet wrote: > > > On 7/24/19 12:01 PM, Eric Dumazet wrote: >> >> >> On 7/24/19 11:17 AM, Mao Wenan wrote: >>> There is one report about tcp_write_xmit use-after-free with version >>> 4.4.136: >> >> Current stable 4.4 is 4.4.186 >> >> Can you check the bug is still

Re: [PATCH 4.4 stable net] net: tcp: Fix use-after-free in tcp_write_xmit

2019-07-24 Thread Eric Dumazet
On 7/24/19 12:46 PM, maowenan wrote: > > > On 2019/7/24 17:45, Eric Dumazet wrote: >> >> >> On 7/24/19 11:17 AM, Mao Wenan wrote: >>> There is one report about tcp_write_xmit use-after-free with version >>> 4.4.136: >>> >>> BUG: KASAN: use-after-free in tcp_skb_pcount include/net/tcp.h:796 [i

Re: [PATCH 4.4 stable net] net: tcp: Fix use-after-free in tcp_write_xmit

2019-07-24 Thread maowenan
On 2019/7/24 18:38, maowenan wrote: > > > On 2019/7/24 18:13, Eric Dumazet wrote: >> >> >> On 7/24/19 12:01 PM, Eric Dumazet wrote: >>> >>> >>> On 7/24/19 11:17 AM, Mao Wenan wrote: There is one report about tcp_write_xmit use-after-free with version 4.4.136: >>> >>> Current stable

Re: [PATCH 4.4 stable net] net: tcp: Fix use-after-free in tcp_write_xmit

2019-07-24 Thread maowenan
On 2019/7/24 19:05, Greg KH wrote: > On Wed, Jul 24, 2019 at 05:17:15PM +0800, Mao Wenan wrote: >> There is one report about tcp_write_xmit use-after-free with version 4.4.136: >> >> BUG: KASAN: use-after-free in tcp_skb_pcount include/net/tcp.h:796 [inline] >> BUG: KASAN: use-after-free in tcp_

Re: [PATCH 4.4 stable net] net: tcp: Fix use-after-free in tcp_write_xmit

2019-07-24 Thread Greg KH
On Wed, Jul 24, 2019 at 05:17:15PM +0800, Mao Wenan wrote: > There is one report about tcp_write_xmit use-after-free with version 4.4.136: > > BUG: KASAN: use-after-free in tcp_skb_pcount include/net/tcp.h:796 [inline] > BUG: KASAN: use-after-free in tcp_init_tso_segs net/ipv4/tcp_output.c:1619 >

Re: [PATCH 4.4 stable net] net: tcp: Fix use-after-free in tcp_write_xmit

2019-07-24 Thread maowenan
On 2019/7/24 17:45, Eric Dumazet wrote: > > > On 7/24/19 11:17 AM, Mao Wenan wrote: >> There is one report about tcp_write_xmit use-after-free with version 4.4.136: >> >> BUG: KASAN: use-after-free in tcp_skb_pcount include/net/tcp.h:796 [inline] >> BUG: KASAN: use-after-free in tcp_init_tso_s

Re: [PATCH 4.4 stable net] net: tcp: Fix use-after-free in tcp_write_xmit

2019-07-24 Thread Eric Dumazet
On 7/24/19 12:36 PM, maowenan wrote: > Actually, I have tested 4.4.184, UAF still happen. > > Thanks for testing. Acked-by: Eric Dumazet

Re: [PATCH 4.4 stable net] net: tcp: Fix use-after-free in tcp_write_xmit

2019-07-24 Thread maowenan
On 2019/7/24 18:13, Eric Dumazet wrote: > > > On 7/24/19 12:01 PM, Eric Dumazet wrote: >> >> >> On 7/24/19 11:17 AM, Mao Wenan wrote: >>> There is one report about tcp_write_xmit use-after-free with version >>> 4.4.136: >> >> Current stable 4.4 is 4.4.186 >> >> Can you check the bug is still

Re: [PATCH 4.4 stable net] net: tcp: Fix use-after-free in tcp_write_xmit

2019-07-24 Thread maowenan
Actually, I have tested 4.4.184, UAF still happen. On 2019/7/24 18:01, Eric Dumazet wrote: > > > On 7/24/19 11:17 AM, Mao Wenan wrote: >> There is one report about tcp_write_xmit use-after-free with version 4.4.136: > > Current stable 4.4 is 4.4.186 > > Can you check the bug is still there ? >

Re: [PATCH 4.4 stable net] net: tcp: Fix use-after-free in tcp_write_xmit

2019-07-24 Thread Eric Dumazet
On 7/24/19 12:01 PM, Eric Dumazet wrote: > > > On 7/24/19 11:17 AM, Mao Wenan wrote: >> There is one report about tcp_write_xmit use-after-free with version 4.4.136: > > Current stable 4.4 is 4.4.186 > > Can you check the bug is still there ? > BTW, I tried the C repro and another bug show

Re: [PATCH 4.4 stable net] net: tcp: Fix use-after-free in tcp_write_xmit

2019-07-24 Thread Eric Dumazet
On 7/24/19 11:17 AM, Mao Wenan wrote: > There is one report about tcp_write_xmit use-after-free with version 4.4.136: Current stable 4.4 is 4.4.186 Can you check the bug is still there ? List of patches between 4.4.136 and 4.4.186 (this list is not exhaustive) 46c7b5d6f2a51c355b29118814fbfbd

Re: [PATCH 4.4 stable net] net: tcp: Fix use-after-free in tcp_write_xmit

2019-07-24 Thread Eric Dumazet
On 7/24/19 11:17 AM, Mao Wenan wrote: > There is one report about tcp_write_xmit use-after-free with version 4.4.136: > > BUG: KASAN: use-after-free in tcp_skb_pcount include/net/tcp.h:796 [inline] > BUG: KASAN: use-after-free in tcp_init_tso_segs net/ipv4/tcp_output.c:1619 > [inline] > BUG: K

Re: [PATCH 4.4 stable net] net: tcp: Fix use-after-free in tcp_write_xmit

2019-07-24 Thread maowenan
Add sta...@vger.kernel.org. On 2019/7/24 17:17, Mao Wenan wrote: > There is one report about tcp_write_xmit use-after-free with version 4.4.136: > > BUG: KASAN: use-after-free in tcp_skb_pcount include/net/tcp.h:796 [inline] > BUG: KASAN: use-after-free in tcp_init_tso_segs net/ipv4/tcp_output.c:

[PATCH 4.4 stable net] net: tcp: Fix use-after-free in tcp_write_xmit

2019-07-24 Thread Mao Wenan
There is one report about tcp_write_xmit use-after-free with version 4.4.136: BUG: KASAN: use-after-free in tcp_skb_pcount include/net/tcp.h:796 [inline] BUG: KASAN: use-after-free in tcp_init_tso_segs net/ipv4/tcp_output.c:1619 [inline] BUG: KASAN: use-after-free in tcp_write_xmit+0x3fc2/0x4cb0