[PATCH 4.4 15/39] geneve: pull IP header before ECN decapsulation

2020-12-10 Thread Greg Kroah-Hartman
From: Eric Dumazet IP_ECN_decapsulate() and IP6_ECN_decapsulate() assume IP header is already pulled. geneve does not ensure this yet. Fixing this generically in IP_ECN_decapsulate() and IP6_ECN_decapsulate() is not possible, since callers pass a pointer that might be freed by pskb_may_pull()

Re: [PATCH 4.4 15/39] geneve: pull IP header before ECN decapsulation

2020-12-10 Thread Greg Kroah-Hartman
On Thu, Dec 10, 2020 at 03:32:12PM +0100, Eric Dumazet wrote: > On Thu, Dec 10, 2020 at 3:26 PM Greg Kroah-Hartman > wrote: > > > > From: Eric Dumazet > > > > IP_ECN_decapsulate() and IP6_ECN_decapsulate() assume > > IP header is already pulled. > > > > geneve does not ensure this yet. > > > > Fi

Re: [PATCH 4.4 15/39] geneve: pull IP header before ECN decapsulation

2020-12-10 Thread Greg Kroah-Hartman
On Thu, Dec 10, 2020 at 03:53:09PM +0100, Eric Dumazet wrote: > On Thu, Dec 10, 2020 at 3:40 PM Greg Kroah-Hartman > wrote: > > > > On Thu, Dec 10, 2020 at 03:38:44PM +0100, Greg Kroah-Hartman wrote: > > > On Thu, Dec 10, 2020 at 03:32:12PM +0100, Eric Dumazet wrote: > > > > On Thu, Dec 10, 2020 a

Re: [PATCH 4.4 15/39] geneve: pull IP header before ECN decapsulation

2020-12-10 Thread Greg Kroah-Hartman
On Thu, Dec 10, 2020 at 03:38:44PM +0100, Greg Kroah-Hartman wrote: > On Thu, Dec 10, 2020 at 03:32:12PM +0100, Eric Dumazet wrote: > > On Thu, Dec 10, 2020 at 3:26 PM Greg Kroah-Hartman > > wrote: > > > > > > From: Eric Dumazet > > > > > > IP_ECN_decapsulate() and IP6_ECN_decapsulate() assume >

Re: [PATCH 4.4 15/39] geneve: pull IP header before ECN decapsulation

2020-12-10 Thread Eric Dumazet
On Thu, Dec 10, 2020 at 3:40 PM Greg Kroah-Hartman wrote: > > On Thu, Dec 10, 2020 at 03:38:44PM +0100, Greg Kroah-Hartman wrote: > > On Thu, Dec 10, 2020 at 03:32:12PM +0100, Eric Dumazet wrote: > > > On Thu, Dec 10, 2020 at 3:26 PM Greg Kroah-Hartman > > > wrote: > > > > > > > > From: Eric Duma

Re: [PATCH 4.4 15/39] geneve: pull IP header before ECN decapsulation

2020-12-10 Thread Eric Dumazet
On Thu, Dec 10, 2020 at 3:26 PM Greg Kroah-Hartman wrote: > > From: Eric Dumazet > > IP_ECN_decapsulate() and IP6_ECN_decapsulate() assume > IP header is already pulled. > > geneve does not ensure this yet. > > Fixing this generically in IP_ECN_decapsulate() and > IP6_ECN_decapsulate() is not pos