Re: [PATCH 4.4 034/131] lib/int_sqrt: optimize small argument

2019-04-02 Thread Greg Kroah-Hartman
On Tue, Apr 02, 2019 at 02:00:06AM -0700, Joe Perches wrote: > On Tue, 2019-04-02 at 08:59 +0200, Greg Kroah-Hartman wrote: > > On Mon, Apr 01, 2019 at 10:42:52AM -0700, Joe Perches wrote: > > > On Mon, 2019-04-01 at 19:01 +0200, Greg Kroah-Hartman wrote: > > > > 4.4-stable review patch. If anyone

Re: [PATCH 4.4 034/131] lib/int_sqrt: optimize small argument

2019-04-02 Thread Joe Perches
On Tue, 2019-04-02 at 08:59 +0200, Greg Kroah-Hartman wrote: > On Mon, Apr 01, 2019 at 10:42:52AM -0700, Joe Perches wrote: > > On Mon, 2019-04-01 at 19:01 +0200, Greg Kroah-Hartman wrote: > > > 4.4-stable review patch. If anyone has any objections, please let me > > > know. > > > > If this is t

Re: [PATCH 4.4 034/131] lib/int_sqrt: optimize small argument

2019-04-02 Thread Greg Kroah-Hartman
On Mon, Apr 01, 2019 at 10:42:52AM -0700, Joe Perches wrote: > On Mon, 2019-04-01 at 19:01 +0200, Greg Kroah-Hartman wrote: > > 4.4-stable review patch. If anyone has any objections, please let me know. > > If this is to be ported just for an optimization > (which I think is dubious as it's not a

Re: [PATCH 4.4 034/131] lib/int_sqrt: optimize small argument

2019-04-01 Thread Joe Perches
On Mon, 2019-04-01 at 19:01 +0200, Greg Kroah-Hartman wrote: > 4.4-stable review patch. If anyone has any objections, please let me know. If this is to be ported just for an optimization (which I think is dubious as it's not a bug fix), why not port the __fls optimization too? __fls has a bigger

[PATCH 4.4 034/131] lib/int_sqrt: optimize small argument

2019-04-01 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Peter Zijlstra commit 3f3295709edea6268ff1609855f498035286af73 upstream. The current int_sqrt() computation is sub-optimal for the case of small @x. Which is the interesting case when we're go