Re: [PATCH 4.14 024/110] btrfs: use proper endianness accessors for super_copy

2018-03-20 Thread Anand Jain
On 03/20/2018 03:32 AM, David Sterba wrote: On Sat, Mar 17, 2018 at 06:27:15PM +0100, Christoph Biedl wrote: Greg Kroah-Hartman wrote... On Thu, Mar 15, 2018 at 07:55:42PM +0100, Christoph Biedl wrote: commit 3c181c12c431fe33b669410d663beb9cceefcd1b upstream. On big-endian systems, thi

Re: [PATCH 4.14 024/110] btrfs: use proper endianness accessors for super_copy

2018-03-19 Thread David Sterba
On Sat, Mar 17, 2018 at 06:27:15PM +0100, Christoph Biedl wrote: > Greg Kroah-Hartman wrote... > > > On Thu, Mar 15, 2018 at 07:55:42PM +0100, Christoph Biedl wrote: > > > > > commit 3c181c12c431fe33b669410d663beb9cceefcd1b upstream. > > > > On big-endian systems, this change intruduces severe c

Re: [PATCH 4.14 024/110] btrfs: use proper endianness accessors for super_copy

2018-03-17 Thread Christoph Biedl
Greg Kroah-Hartman wrote... > On Thu, Mar 15, 2018 at 07:55:42PM +0100, Christoph Biedl wrote: > > > commit 3c181c12c431fe33b669410d663beb9cceefcd1b upstream. > > On big-endian systems, this change intruduces severe corruption, > > resulting in complete loss of the data on the used block device.

Re: [PATCH 4.14 024/110] btrfs: use proper endianness accessors for super_copy

2018-03-16 Thread Anand Jain
On 03/16/2018 10:02 PM, Greg Kroah-Hartman wrote: On Fri, Mar 16, 2018 at 02:22:02PM +0100, David Sterba wrote: On Fri, Mar 16, 2018 at 01:30:49PM +0100, Greg Kroah-Hartman wrote: On Thu, Mar 15, 2018 at 07:55:42PM +0100, Christoph Biedl wrote: Greg Kroah-Hartman wrote... 4.14-stable revie

Re: [PATCH 4.14 024/110] btrfs: use proper endianness accessors for super_copy

2018-03-16 Thread Anand Jain
On 03/16/2018 02:55 AM, Christoph Biedl wrote: Greg Kroah-Hartman wrote... 4.14-stable review patch. If anyone has any objections, please let me know. commit 3c181c12c431fe33b669410d663beb9cceefcd1b upstream. (...) If the filesystem is always used on a same endian host, this will not b

Re: [PATCH 4.14 024/110] btrfs: use proper endianness accessors for super_copy

2018-03-16 Thread Greg Kroah-Hartman
On Fri, Mar 16, 2018 at 02:22:02PM +0100, David Sterba wrote: > On Fri, Mar 16, 2018 at 01:30:49PM +0100, Greg Kroah-Hartman wrote: > > On Thu, Mar 15, 2018 at 07:55:42PM +0100, Christoph Biedl wrote: > > > Greg Kroah-Hartman wrote... > > > > > > > 4.14-stable review patch. If anyone has any obje

Re: [PATCH 4.14 024/110] btrfs: use proper endianness accessors for super_copy

2018-03-16 Thread David Sterba
On Fri, Mar 16, 2018 at 01:30:49PM +0100, Greg Kroah-Hartman wrote: > On Thu, Mar 15, 2018 at 07:55:42PM +0100, Christoph Biedl wrote: > > Greg Kroah-Hartman wrote... > > > > > 4.14-stable review patch. If anyone has any objections, please let me > > > know. > > > > > commit 3c181c12c431fe33b66

Re: [PATCH 4.14 024/110] btrfs: use proper endianness accessors for super_copy

2018-03-16 Thread Greg Kroah-Hartman
On Thu, Mar 15, 2018 at 07:55:42PM +0100, Christoph Biedl wrote: > Greg Kroah-Hartman wrote... > > > 4.14-stable review patch. If anyone has any objections, please let me know. > > > commit 3c181c12c431fe33b669410d663beb9cceefcd1b upstream. > (...) > > > If the filesystem is always used on a sa

Re: [PATCH 4.14 024/110] btrfs: use proper endianness accessors for super_copy

2018-03-15 Thread Christoph Biedl
Greg Kroah-Hartman wrote... > 4.14-stable review patch. If anyone has any objections, please let me know. > commit 3c181c12c431fe33b669410d663beb9cceefcd1b upstream. (...) > If the filesystem is always used on a same endian host, this will not > be a problem. >From my observations I cannot qui

[PATCH 4.14 024/110] btrfs: use proper endianness accessors for super_copy

2018-03-07 Thread Greg Kroah-Hartman
4.14-stable review patch. If anyone has any objections, please let me know. -- From: Anand Jain commit 3c181c12c431fe33b669410d663beb9cceefcd1b upstream. The fs_info::super_copy is a byte copy of the on-disk structure and all members must use the accessor macros/functions to o