Re: [PATCH 4.1 108/159] stmmac: fix check for phydev being open

2015-10-01 Thread Sergei Shtylyov
On 10/1/2015 6:04 AM, Greg Kroah-Hartman wrote: 4.1-stable review patch. If anyone has any objections, please let me know. NAK on the same grounds as the 3.x patches. of_phy_connect() isn't called yet. If the patch has been committed already, it's OK -- it should do no harm. Yeah, it's

Re: [PATCH 4.1 108/159] stmmac: fix check for phydev being open

2015-09-30 Thread Greg Kroah-Hartman
On Wed, Sep 30, 2015 at 02:25:43PM +0300, Sergei Shtylyov wrote: > Hello. > > On 9/26/2015 11:55 PM, Greg Kroah-Hartman wrote: > > >4.1-stable review patch. If anyone has any objections, please let me know. > >NAK on the same grounds as the 3.x patches. of_phy_connect() isn't called > yet.

Re: [PATCH 4.1 108/159] stmmac: fix check for phydev being open

2015-09-30 Thread Sergei Shtylyov
Hello. On 9/26/2015 11:55 PM, Greg Kroah-Hartman wrote: 4.1-stable review patch. If anyone has any objections, please let me know. NAK on the same grounds as the 3.x patches. of_phy_connect() isn't called yet. If the patch has been committed already, it's OK -- it should do no harm. -

[PATCH 4.1 108/159] stmmac: fix check for phydev being open

2015-09-26 Thread Greg Kroah-Hartman
4.1-stable review patch. If anyone has any objections, please let me know. -- From: Alexey Brodkin commit dfc50fcaad574e5c8c85cbc83eca1426b2413fa4 upstream. Current check of phydev with IS_ERR(phydev) may make not much sense because of_phy_connect() returns NULL on failure ins