Re: [PATCH 4 of 4] x86: mask NX from pte_pfn

2008-01-18 Thread Jeremy Fitzhardinge
Hugh Dickins wrote: Shouldn't that be return (pte_val(pte) & ~_PAGE_NX) >> PAGE_SHIFT; Yes, it should be. Thanks, J -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel

Re: [PATCH 4 of 4] x86: mask NX from pte_pfn

2008-01-18 Thread Ingo Molnar
* Hugh Dickins <[EMAIL PROTECTED]> wrote: > > - return pte_val(pte) >> PAGE_SHIFT; > > + return (pte_val(pte) >> PAGE_SHIFT) & ~_PAGE_NX; > Shouldn't that be > > return (pte_val(pte) & ~_PAGE_NX) >> PAGE_SHIFT; ouch! Sharp eyes! Fixed it. Ingo -- To unsubscribe from this lis

Re: [PATCH 4 of 4] x86: mask NX from pte_pfn

2008-01-18 Thread Hugh Dickins
On Tue, 15 Jan 2008, Jeremy Fitzhardinge wrote: > In 32-bit PAE, mask NX from pte_pfn, since it isn't part of the PFN. > This code is due for unification anyway, but this fixes a latent bug. > > Signed-off-by: Jeremy Fitzhardinge <[EMAIL PROTECTED]> > > --- > include/asm-x86/pgtable-3level.h |

[PATCH 4 of 4] x86: mask NX from pte_pfn

2008-01-15 Thread Jeremy Fitzhardinge
In 32-bit PAE, mask NX from pte_pfn, since it isn't part of the PFN. This code is due for unification anyway, but this fixes a latent bug. Signed-off-by: Jeremy Fitzhardinge <[EMAIL PROTECTED]> --- include/asm-x86/pgtable-3level.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --