Re: [PATCH 4/9] sched: Move SCHED_DEBUG to debugfs

2021-04-07 Thread Valentin Schneider
On 07/04/21 14:26, Peter Zijlstra wrote: > On Wed, Apr 07, 2021 at 11:46:43AM +0100, Valentin Schneider wrote: >> I can't find the threads in a hurry, but ISTR justifications for keeping >> this around were: >> - Most distros have CONFIG_SCHED_DEBUG=y because knobs and ponies >> - Topology debug pr

Re: [PATCH 4/9] sched: Move SCHED_DEBUG to debugfs

2021-04-07 Thread Peter Zijlstra
On Wed, Apr 07, 2021 at 11:46:43AM +0100, Valentin Schneider wrote: > On 26/03/21 11:33, Peter Zijlstra wrote: > > __read_mostly bool sched_debug_enabled; > > > > +struct dentry *debugfs_sched; > > + > > static __init int sched_init_debug(void) > > { > > - debugfs_create_file("sched_features

Re: [PATCH 4/9] sched: Move SCHED_DEBUG to debugfs

2021-04-07 Thread Valentin Schneider
On 26/03/21 11:33, Peter Zijlstra wrote: > __read_mostly bool sched_debug_enabled; > > +struct dentry *debugfs_sched; > + > static __init int sched_init_debug(void) > { > - debugfs_create_file("sched_features", 0644, NULL, NULL, > - &sched_feat_fops); > + struct den

Re: [PATCH 4/9] sched: Move SCHED_DEBUG to debugfs

2021-03-26 Thread Greg KH
On Fri, Mar 26, 2021 at 11:33:56AM +0100, Peter Zijlstra wrote: > Stop polluting sysctl with undocumented knobs that really are debug > only, move them all to /debug/sched/ along with the existing > /debug/sched_* files that already exist. > > Signed-off-by: Peter Zijlstra (Intel) > --- > includ

[PATCH 4/9] sched: Move SCHED_DEBUG to debugfs

2021-03-26 Thread Peter Zijlstra
Stop polluting sysctl with undocumented knobs that really are debug only, move them all to /debug/sched/ along with the existing /debug/sched_* files that already exist. Signed-off-by: Peter Zijlstra (Intel) --- include/linux/sched/sysctl.h |8 +-- kernel/sched/core.c |4 + kern