Re: [PATCH 4/9] mailbox: tegra-hsp: Add support for shared mailboxes

2018-10-30 Thread Pekka Pessi
I guess it being an example doesn't make it strictly a recommendation, but I wonder if we should avoid giving examples that use mappings which we discourage. Well, yes, that is example for top0 – but I agree, giving examples that do not make much sense is not very productive. So currently we

Re: [PATCH 4/9] mailbox: tegra-hsp: Add support for shared mailboxes

2018-10-29 Thread Thierry Reding
On Mon, Oct 29, 2018 at 02:25:42PM +0200, Pekka Pessi wrote: > Hi Thierry, > > From the 0/9: > > Are you aware of any others that we need to take into account? > We would like to use upstream driver for RCE (and probably AON and SCE) > mailbox handling, too. Eventually. > > This is a bit > > of a

Re: [PATCH 4/9] mailbox: tegra-hsp: Add support for shared mailboxes

2018-10-29 Thread Pekka Pessi
Hi Thierry, From the 0/9: Are you aware of any others that we need to take into account? We would like to use upstream driver for RCE (and probably AON and SCE) mailbox handling, too. Eventually. This is a bit of a problem because the mailbox driver doesn't really know anything about the direc

Re: [PATCH 4/9] mailbox: tegra-hsp: Add support for shared mailboxes

2018-10-29 Thread Thierry Reding
On Mon, Oct 29, 2018 at 12:04:22PM +0200, Pekka Pessi wrote: > Hi Thierry, > > There is typically one entity (aux cpu or a VM running on CCPLEX) owning the > "empty" or producer side of mailbox (iow, waking up on empty) and another > entity owning the "full" or consumer side of mailbox (waking up

Re: [PATCH 4/9] mailbox: tegra-hsp: Add support for shared mailboxes

2018-10-29 Thread Pekka Pessi
Hi Thierry, There is typically one entity (aux cpu or a VM running on CCPLEX) owning the "empty" or producer side of mailbox (iow, waking up on empty) and another entity owning the "full" or consumer side of mailbox (waking up on full). An entity should not muck with the interrupts used by the

[PATCH 4/9] mailbox: tegra-hsp: Add support for shared mailboxes

2018-10-26 Thread Thierry Reding
From: Thierry Reding The Tegra HSP block supports 'shared mailboxes' that are simple 32-bit registers consisting of a FULL bit in MSB position and 31 bits of data. The hardware can be configured to trigger interrupts when a mailbox is empty or full. Add support for these shared mailboxes to the H