Re: [PATCH 4/9] Factor common inode cluster buffer lookup code

2007-11-23 Thread Christoph Hellwig
On Thu, Nov 22, 2007 at 11:36:42AM +1100, David Chinner wrote: > +STATIC int > +xfs_ino_to_imap( > + xfs_mount_t *mp, > + xfs_trans_t *tp, > + xfs_ino_t ino, > + xfs_imap_t *imap, > + uintimap_flags) > +{ > + int error; > + > +

[PATCH 4/9] Factor common inode cluster buffer lookup code

2007-11-21 Thread David Chinner
Factor xfs_itobp() and xfs_inotobp(). The only difference between the functions is one passes an inode for the lookup, the other passes an inode number. However, they don't do the same validity checking or set all the same state on the buffer that is returned yet they should. Factor the functions