Re: [PATCH 4/7] netprio_cgroup: reimplement priomap expansion

2012-11-20 Thread Daniel Wagner
On 20.11.2012 16:13, Tejun Heo wrote: Hello, On Tue, Nov 20, 2012 at 04:09:22PM +0100, Daniel Wagner wrote: Thanks for the explanation. I was pondering if the new size in power of two could be a bit too excessive and the allocation step could be linear, e.g. stick at 4096. target_id will increa

Re: [PATCH 4/7] netprio_cgroup: reimplement priomap expansion

2012-11-20 Thread Tejun Heo
Hello, On Tue, Nov 20, 2012 at 04:09:22PM +0100, Daniel Wagner wrote: > Thanks for the explanation. I was pondering if the new size in power > of two could be a bit too excessive and the allocation step could be > linear, e.g. stick at 4096. target_id will increase linear, > therefore linear incre

Re: [PATCH 4/7] netprio_cgroup: reimplement priomap expansion

2012-11-20 Thread Daniel Wagner
On 20.11.2012 15:38, Tejun Heo wrote: Hello, Daniel. On Tue, Nov 20, 2012 at 09:46:22AM +0100, Daniel Wagner wrote: struct netprio_map { struct rcu_head rcu; struct netprio_aux *aux;/* auxiliary config array */ u32 priomap_len; u32 priomap[]; }; Is there

Re: [PATCH 4/7] netprio_cgroup: reimplement priomap expansion

2012-11-20 Thread Tejun Heo
Hello, Daniel. On Tue, Nov 20, 2012 at 09:46:22AM +0100, Daniel Wagner wrote: > struct netprio_map { > struct rcu_head rcu; > struct netprio_aux *aux;/* auxiliary config array */ > u32 priomap_len; > u32 priomap[]; > }; > > Is there a specific reason why aux and pr

Re: [PATCH 4/7] netprio_cgroup: reimplement priomap expansion

2012-11-20 Thread Daniel Wagner
Hi Tejun, On 20.11.2012 09:30, Tejun Heo wrote: > netprio kept track of the highest prioidx allocated and resized > priomaps accordingly when necessary. This makes it necessary to keep > track of prioidx allocation and may end up resizing on every new > prioidx. > > Update extend_netdev_table()

[PATCH 4/7] netprio_cgroup: reimplement priomap expansion

2012-11-20 Thread Tejun Heo
netprio kept track of the highest prioidx allocated and resized priomaps accordingly when necessary. This makes it necessary to keep track of prioidx allocation and may end up resizing on every new prioidx. Update extend_netdev_table() such that it takes @target_idx which the priomap should be ab

[PATCH 4/7] netprio_cgroup: reimplement priomap expansion

2012-11-19 Thread Tejun Heo
netprio kept track of the highest prioidx allocated and resized priomaps accordingly when necessary. This makes it necessary to keep track of prioidx allocation and may end up resizing on every new prioidx. Update extend_netdev_table() such that it takes @target_idx which the priomap should be ab