Re: [PATCH 4/6 v3] ftrace/x86_32: Clean up ftrace_regs_caller

2017-03-20 Thread Josh Poimboeuf
On Sat, Mar 18, 2017 at 05:09:27PM -0400, Steven Rostedt wrote: > @@ -111,12 +114,11 @@ GLOBAL(ftrace_regs_call) > popl%es > popl%fs > popl%gs > - addl$8, %esp/* Skip orig_ax and ip */ > - popf/* P

[PATCH 4/6 v3] ftrace/x86_32: Clean up ftrace_regs_caller

2017-03-18 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" When ftrace_regs_caller was created, it was designed to preserve flags as much as possible as it needed to act just like a breakpoint triggered on the same location. But the design is over complicated as it treated all operations as modifying flags. But push, mov a