Re: [PATCH 4/6] mm/hotplug: Reorder arch_remove_memory() call in __remove_memory()

2019-04-04 Thread Anshuman Khandual
On 04/03/2019 02:47 PM, Michal Hocko wrote: > On Wed 03-04-19 10:00:04, Anshuman Khandual wrote: >> Memory hot remove uses get_nid_for_pfn() while tearing down linked sysfs >> entries between memory block and node. It first checks pfn validity with >> pfn_valid_within() before fetching nid. With

Re: [PATCH 4/6] mm/hotplug: Reorder arch_remove_memory() call in __remove_memory()

2019-04-03 Thread David Hildenbrand
On 03.04.19 06:30, Anshuman Khandual wrote: > Memory hot remove uses get_nid_for_pfn() while tearing down linked sysfs > entries between memory block and node. It first checks pfn validity with > pfn_valid_within() before fetching nid. With CONFIG_HOLES_IN_ZONE config > (arm64 has this enabled) pfn

Re: [PATCH 4/6] mm/hotplug: Reorder arch_remove_memory() call in __remove_memory()

2019-04-03 Thread Michal Hocko
On Wed 03-04-19 10:00:04, Anshuman Khandual wrote: > Memory hot remove uses get_nid_for_pfn() while tearing down linked sysfs > entries between memory block and node. It first checks pfn validity with > pfn_valid_within() before fetching nid. With CONFIG_HOLES_IN_ZONE config > (arm64 has this enabl

Re: [PATCH 4/6] mm/hotplug: Reorder arch_remove_memory() call in __remove_memory()

2019-04-03 Thread Oscar Salvador
On Wed, Apr 03, 2019 at 10:00:04AM +0530, Anshuman Khandual wrote: > Re-ordering arch_remove_memory() with memblock_[free|remove] solves the > problem on arm64 as pfn_valid() behaves correctly and returns positive > as memblock for the address range still exists. arch_remove_memory() > removes appl

[PATCH 4/6] mm/hotplug: Reorder arch_remove_memory() call in __remove_memory()

2019-04-02 Thread Anshuman Khandual
Memory hot remove uses get_nid_for_pfn() while tearing down linked sysfs entries between memory block and node. It first checks pfn validity with pfn_valid_within() before fetching nid. With CONFIG_HOLES_IN_ZONE config (arm64 has this enabled) pfn_valid_within() calls pfn_valid(). pfn_valid() is a