Re: [PATCH 4/5] perf tools: Propagate error info from tp_format

2015-09-14 Thread Arnaldo Carvalho de Melo
Em Mon, Sep 14, 2015 at 06:05:38PM -0400, Raphaël Beamonte escreveu: > 2015-09-14 17:36 GMT-04:00 Arnaldo Carvalho de Melo : > > Em Mon, Sep 14, 2015 at 04:59:41PM -0400, Raphaël Beamonte escreveu: > >> 2015-09-14 16:53 GMT-04:00 Arnaldo Carvalho de Melo > >> : > >> > +++ b/tools/perf/util/evsel.c

Re: [PATCH 4/5] perf tools: Propagate error info from tp_format

2015-09-14 Thread Raphaël Beamonte
2015-09-14 17:36 GMT-04:00 Arnaldo Carvalho de Melo : > Em Mon, Sep 14, 2015 at 04:59:41PM -0400, Raphaël Beamonte escreveu: >> 2015-09-14 16:53 GMT-04:00 Arnaldo Carvalho de Melo : >> > +++ b/tools/perf/util/evsel.c >> > @@ -234,7 +234,9 @@ struct perf_evsel *perf_evsel__newtp_idx(const char >> >

Re: [PATCH 4/5] perf tools: Propagate error info from tp_format

2015-09-14 Thread Arnaldo Carvalho de Melo
Em Mon, Sep 14, 2015 at 04:59:41PM -0400, Raphaël Beamonte escreveu: > 2015-09-14 16:53 GMT-04:00 Arnaldo Carvalho de Melo : > > +++ b/tools/perf/util/evsel.c > > @@ -234,7 +234,9 @@ struct perf_evsel *perf_evsel__newtp_idx(const char > > *sys, const char *name, int > > struct perf_evsel *

Re: [PATCH 4/5] perf tools: Propagate error info from tp_format

2015-09-14 Thread Arnaldo Carvalho de Melo
Em Mon, Sep 14, 2015 at 05:53:03PM -0300, Arnaldo Carvalho de Melo escreveu: > Ok continuing, found two more problems in this patch, fixed as follows, > merging. > - Arnaldo > +++ b/tools/perf/tests/mmap-basic.c > @@ -65,7 +65,7 @@ int test__basic_mmap(void) > > snprintf(name, s

Re: [PATCH 4/5] perf tools: Propagate error info from tp_format

2015-09-14 Thread Raphaël Beamonte
2015-09-14 16:53 GMT-04:00 Arnaldo Carvalho de Melo : > Em Thu, Sep 10, 2015 at 10:24:52AM +0200, Jiri Olsa escreveu: >> On Wed, Sep 09, 2015 at 05:58:13PM -0300, Arnaldo Carvalho de Melo wrote: >> >> SNIP >> >> > This kind of stuff is ok, as evsel is a local variable and you kept the >> > interfac

Re: [PATCH 4/5] perf tools: Propagate error info from tp_format

2015-09-14 Thread Arnaldo Carvalho de Melo
Em Thu, Sep 10, 2015 at 10:24:52AM +0200, Jiri Olsa escreveu: > On Wed, Sep 09, 2015 at 05:58:13PM -0300, Arnaldo Carvalho de Melo wrote: > > SNIP > > > This kind of stuff is ok, as evsel is a local variable and you kept the > > interface for perf_evsel__syscall_newtp(), i.e. it returns NULL if a

Re: [PATCH 4/5] perf tools: Propagate error info from tp_format

2015-09-10 Thread Arnaldo Carvalho de Melo
Em Thu, Sep 10, 2015 at 10:24:52AM +0200, Jiri Olsa escreveu: > On Wed, Sep 09, 2015 at 05:58:13PM -0300, Arnaldo Carvalho de Melo wrote: > > SNIP > > > This kind of stuff is ok, as evsel is a local variable and you kept the > > interface for perf_evsel__syscall_newtp(), i.e. it returns NULL if a

Re: [PATCH 4/5] perf tools: Propagate error info from tp_format

2015-09-10 Thread Jiri Olsa
On Wed, Sep 09, 2015 at 05:58:13PM -0300, Arnaldo Carvalho de Melo wrote: SNIP > This kind of stuff is ok, as evsel is a local variable and you kept the > interface for perf_evsel__syscall_newtp(), i.e. it returns NULL if a new > evsel can't be instantiated. > > Ok, but that is a different inter

Re: [PATCH 4/5] perf tools: Propagate error info from tp_format

2015-09-09 Thread Arnaldo Carvalho de Melo
Em Mon, Sep 07, 2015 at 10:38:06AM +0200, Jiri Olsa escreveu: > Propagate error info from tp_format via ERR_PTR to get > it all the way down to the parse-event.c tracepoint adding > routines. Following functions now return pointer with > encoded error: > - tp_format > - trace_event__tp_format >

[PATCH 4/5] perf tools: Propagate error info from tp_format

2015-09-07 Thread Jiri Olsa
Propagate error info from tp_format via ERR_PTR to get it all the way down to the parse-event.c tracepoint adding routines. Following functions now return pointer with encoded error: - tp_format - trace_event__tp_format - perf_evsel__newtp_idx - perf_evsel__newtp This affects several other