Re: [PATCH 4/5] mm/hmm: hmm_vma_fault() doesn't always call hmm_range_unregister()

2019-06-06 Thread Ralph Campbell
On 6/6/19 12:54 PM, Jason Gunthorpe wrote: On Thu, Jun 06, 2019 at 12:44:36PM -0700, Ralph Campbell wrote: On 6/6/19 7:50 AM, Jason Gunthorpe wrote: On Mon, May 06, 2019 at 04:29:41PM -0700, rcampb...@nvidia.com wrote: From: Ralph Campbell The helper function hmm_vma_fault() calls hmm_ran

Re: [PATCH 4/5] mm/hmm: hmm_vma_fault() doesn't always call hmm_range_unregister()

2019-06-06 Thread Jason Gunthorpe
On Thu, Jun 06, 2019 at 12:44:36PM -0700, Ralph Campbell wrote: > > On 6/6/19 7:50 AM, Jason Gunthorpe wrote: > > On Mon, May 06, 2019 at 04:29:41PM -0700, rcampb...@nvidia.com wrote: > > > From: Ralph Campbell > > > > > > The helper function hmm_vma_fault() calls hmm_range_register() but is > >

Re: [PATCH 4/5] mm/hmm: hmm_vma_fault() doesn't always call hmm_range_unregister()

2019-06-06 Thread Ralph Campbell
On 6/6/19 7:50 AM, Jason Gunthorpe wrote: On Mon, May 06, 2019 at 04:29:41PM -0700, rcampb...@nvidia.com wrote: From: Ralph Campbell The helper function hmm_vma_fault() calls hmm_range_register() but is missing a call to hmm_range_unregister() in one of the error paths. This leads to a refer

Re: [PATCH 4/5] mm/hmm: hmm_vma_fault() doesn't always call hmm_range_unregister()

2019-06-06 Thread Jason Gunthorpe
On Mon, May 06, 2019 at 04:29:41PM -0700, rcampb...@nvidia.com wrote: > From: Ralph Campbell > > The helper function hmm_vma_fault() calls hmm_range_register() but is > missing a call to hmm_range_unregister() in one of the error paths. > This leads to a reference count leak and ultimately a memo

Re: [PATCH 4/5] mm/hmm: hmm_vma_fault() doesn't always call hmm_range_unregister()

2019-05-13 Thread Ralph Campbell
On 5/12/19 8:07 AM, Jerome Glisse wrote: On Tue, May 07, 2019 at 11:12:14AM -0700, Ralph Campbell wrote: On 5/7/19 6:15 AM, Souptick Joarder wrote: On Tue, May 7, 2019 at 5:00 AM wrote: From: Ralph Campbell The helper function hmm_vma_fault() calls hmm_range_register() but is missing a

Re: [PATCH 4/5] mm/hmm: hmm_vma_fault() doesn't always call hmm_range_unregister()

2019-05-12 Thread Jerome Glisse
On Sun, May 12, 2019 at 11:07:24AM -0400, Jerome Glisse wrote: > On Tue, May 07, 2019 at 11:12:14AM -0700, Ralph Campbell wrote: > > > > On 5/7/19 6:15 AM, Souptick Joarder wrote: > > > On Tue, May 7, 2019 at 5:00 AM wrote: > > > > > > > > From: Ralph Campbell > > > > > > > > The helper functi

Re: [PATCH 4/5] mm/hmm: hmm_vma_fault() doesn't always call hmm_range_unregister()

2019-05-12 Thread Jerome Glisse
On Tue, May 07, 2019 at 11:12:14AM -0700, Ralph Campbell wrote: > > On 5/7/19 6:15 AM, Souptick Joarder wrote: > > On Tue, May 7, 2019 at 5:00 AM wrote: > > > > > > From: Ralph Campbell > > > > > > The helper function hmm_vma_fault() calls hmm_range_register() but is > > > missing a call to hm

Re: [PATCH 4/5] mm/hmm: hmm_vma_fault() doesn't always call hmm_range_unregister()

2019-05-08 Thread Souptick Joarder
On Tue, May 7, 2019 at 11:42 PM Ralph Campbell wrote: > > > On 5/7/19 6:15 AM, Souptick Joarder wrote: > > On Tue, May 7, 2019 at 5:00 AM wrote: > >> > >> From: Ralph Campbell > >> > >> The helper function hmm_vma_fault() calls hmm_range_register() but is > >> missing a call to hmm_range_unregis

Re: [PATCH 4/5] mm/hmm: hmm_vma_fault() doesn't always call hmm_range_unregister()

2019-05-07 Thread Ralph Campbell
On 5/7/19 6:15 AM, Souptick Joarder wrote: On Tue, May 7, 2019 at 5:00 AM wrote: From: Ralph Campbell The helper function hmm_vma_fault() calls hmm_range_register() but is missing a call to hmm_range_unregister() in one of the error paths. This leads to a reference count leak and ultimatel

Re: [PATCH 4/5] mm/hmm: hmm_vma_fault() doesn't always call hmm_range_unregister()

2019-05-07 Thread Souptick Joarder
On Tue, May 7, 2019 at 5:00 AM wrote: > > From: Ralph Campbell > > The helper function hmm_vma_fault() calls hmm_range_register() but is > missing a call to hmm_range_unregister() in one of the error paths. > This leads to a reference count leak and ultimately a memory leak on > struct hmm. > > A

[PATCH 4/5] mm/hmm: hmm_vma_fault() doesn't always call hmm_range_unregister()

2019-05-06 Thread rcampbell
From: Ralph Campbell The helper function hmm_vma_fault() calls hmm_range_register() but is missing a call to hmm_range_unregister() in one of the error paths. This leads to a reference count leak and ultimately a memory leak on struct hmm. Always call hmm_range_unregister() if hmm_range_register