Re: [PATCH 4/5] kbuild: disable KBUILD_MODNAME when building for mod.a

2018-07-05 Thread NeilBrown
On Thu, Jul 05 2018, Masahiro Yamada wrote: > 2018-07-05 6:54 GMT+09:00 NeilBrown : >> On Wed, Jul 04 2018, Masahiro Yamada wrote: >> >>> 2018-07-04 7:14 GMT+09:00 NeilBrown : Where I've been using these patches I've sometimes been adding ccflags-y += -DKBUILD_MODNAME='"FOO"'

Re: [PATCH 4/5] kbuild: disable KBUILD_MODNAME when building for mod.a

2018-07-05 Thread Masahiro Yamada
2018-07-05 6:54 GMT+09:00 NeilBrown : > On Wed, Jul 04 2018, Masahiro Yamada wrote: > >> 2018-07-04 7:14 GMT+09:00 NeilBrown : >>> >>> Where I've been using these patches I've sometimes been adding >>> >>> ccflags-y += -DKBUILD_MODNAME='"FOO"' >>> >>> to Makefiles so that modules_params get handl

Re: [PATCH 4/5] kbuild: disable KBUILD_MODNAME when building for mod.a

2018-07-04 Thread NeilBrown
On Wed, Jul 04 2018, Masahiro Yamada wrote: > 2018-07-04 7:14 GMT+09:00 NeilBrown : >> >> Where I've been using these patches I've sometimes been adding >> >> ccflags-y += -DKBUILD_MODNAME='"FOO"' >> >> to Makefiles so that modules_params get handled correctly on non-module >> builds. I've thou

Re: [PATCH 4/5] kbuild: disable KBUILD_MODNAME when building for mod.a

2018-07-04 Thread Masahiro Yamada
2018-07-04 7:14 GMT+09:00 NeilBrown : > On Wed, Jun 27 2018, Masahiro Yamada wrote: > >> 2018-06-18 13:55 GMT+09:00 NeilBrown : >>> When building an object to be included in mod.a we >>> cannot know the name of the module. So don't define >>> KBUILD_MODNAME. This will ensure attempt to use >>> th

Re: [PATCH 4/5] kbuild: disable KBUILD_MODNAME when building for mod.a

2018-07-03 Thread NeilBrown
On Wed, Jun 27 2018, Masahiro Yamada wrote: > 2018-06-18 13:55 GMT+09:00 NeilBrown : >> When building an object to be included in mod.a we >> cannot know the name of the module. So don't define >> KBUILD_MODNAME. This will ensure attempt to use >> that macro when the module name isn't know will

Re: [PATCH 4/5] kbuild: disable KBUILD_MODNAME when building for mod.a

2018-06-26 Thread Masahiro Yamada
2018-06-18 13:55 GMT+09:00 NeilBrown : > When building an object to be included in mod.a we > cannot know the name of the module. So don't define > KBUILD_MODNAME. This will ensure attempt to use > that macro when the module name isn't know will > trigger an error. Honestly, I hate KBUILD_MODNAM

[PATCH 4/5] kbuild: disable KBUILD_MODNAME when building for mod.a

2018-06-17 Thread NeilBrown
When building an object to be included in mod.a we cannot know the name of the module. So don't define KBUILD_MODNAME. This will ensure attempt to use that macro when the module name isn't know will trigger an error. Signed-off-by: NeilBrown --- scripts/Makefile.lib |4 ++-- 1 file changed