Re: [PATCH 4/5] input: touchscreen: support Allwinner SoCs' touchscreen

2016-09-27 Thread Jonathan Cameron
On 25/09/16 20:44, Quentin Schulz wrote: > On 24/07/2016 13:24, Jonathan Cameron wrote: >> On 20/07/16 09:29, Quentin Schulz wrote: >>> This adds support for Allwinner SoCs' (A10, A13 and A31) resistive >>> touchscreen. This driver is probed by the MFD sunxi-gpadc-mfd. >>> >>> This driver uses ADC

Re: [PATCH 4/5] input: touchscreen: support Allwinner SoCs' touchscreen

2016-09-25 Thread Quentin Schulz
On 24/07/2016 13:24, Jonathan Cameron wrote: > On 20/07/16 09:29, Quentin Schulz wrote: >> This adds support for Allwinner SoCs' (A10, A13 and A31) resistive >> touchscreen. This driver is probed by the MFD sunxi-gpadc-mfd. >> >> This driver uses ADC channels exposed through the IIO framework by >>

Re: [PATCH 4/5] input: touchscreen: support Allwinner SoCs' touchscreen

2016-09-24 Thread Dmitry Torokhov
Hi Quentin, On Sat, Sep 24, 2016 at 08:26:08PM +0200, Quentin Schulz wrote: > Hi Dimitry, > > Sorry for the (long) delay, I did not have time to work on it. I'll > mainly work in my free time now. > > On 20/07/2016 19:25, Dmitry Torokhov wrote: > > Hi Quentin, > > > > On Wed, Jul 20, 2016 at 10

Re: [PATCH 4/5] input: touchscreen: support Allwinner SoCs' touchscreen

2016-09-24 Thread Quentin Schulz
Hi Dimitry, Sorry for the (long) delay, I did not have time to work on it. I'll mainly work in my free time now. On 20/07/2016 19:25, Dmitry Torokhov wrote: > Hi Quentin, > > On Wed, Jul 20, 2016 at 10:29:10AM +0200, Quentin Schulz wrote: >> This adds support for Allwinner SoCs' (A10, A13 and A3

Re: [PATCH 4/5] input: touchscreen: support Allwinner SoCs' touchscreen

2016-07-26 Thread Maxime Ripard
Hi, On Mon, Jul 25, 2016 at 10:08:39AM -0700, Dmitry Torokhov wrote: > > > > ... but your driver isn't registered yet. How does input_report and > > > > input_sync behave in such a case? > > > > > > This is explicitly allowed: > > > > > > " > > > ... > > > * NOTE: input_event() may be safely us

Re: [PATCH 4/5] input: touchscreen: support Allwinner SoCs' touchscreen

2016-07-25 Thread Dmitry Torokhov
On Mon, Jul 25, 2016 at 11:45:42AM +0200, maxime.rip...@free-electrons.com wrote: > Hi Dmitry, > > On Wed, Jul 20, 2016 at 11:41:40PM -0700, Dmitry Torokhov wrote: > > On Thu, Jul 21, 2016 at 08:29:50AM +0200, Maxime Ripard wrote: > > > On Wed, Jul 20, 2016 at 10:29:10AM +0200, Quentin Schulz wro

Re: [PATCH 4/5] input: touchscreen: support Allwinner SoCs' touchscreen

2016-07-25 Thread maxime . ripard
Hi Dmitry, On Wed, Jul 20, 2016 at 11:41:40PM -0700, Dmitry Torokhov wrote: > On Thu, Jul 21, 2016 at 08:29:50AM +0200, Maxime Ripard wrote: > > On Wed, Jul 20, 2016 at 10:29:10AM +0200, Quentin Schulz wrote: > > > + irq = regmap_irq_get_virq(sunxi_gpadc_mfd_dev->regmap_irqc, irq); > > > + ret = d

Re: [PATCH 4/5] input: touchscreen: support Allwinner SoCs' touchscreen

2016-07-24 Thread Jonathan Cameron
On 20/07/16 09:29, Quentin Schulz wrote: > This adds support for Allwinner SoCs' (A10, A13 and A31) resistive > touchscreen. This driver is probed by the MFD sunxi-gpadc-mfd. > > This driver uses ADC channels exposed through the IIO framework by > sunxi-gpadc-iio to get its data. When opening this

Re: [PATCH 4/5] input: touchscreen: support Allwinner SoCs' touchscreen

2016-07-20 Thread Dmitry Torokhov
On Thu, Jul 21, 2016 at 08:29:50AM +0200, Maxime Ripard wrote: > On Wed, Jul 20, 2016 at 10:29:10AM +0200, Quentin Schulz wrote: > > + irq = regmap_irq_get_virq(sunxi_gpadc_mfd_dev->regmap_irqc, irq); > > + ret = devm_request_any_context_irq(&pdev->dev, irq, > > +

Re: [PATCH 4/5] input: touchscreen: support Allwinner SoCs' touchscreen

2016-07-20 Thread Maxime Ripard
On Wed, Jul 20, 2016 at 10:29:10AM +0200, Quentin Schulz wrote: > This adds support for Allwinner SoCs' (A10, A13 and A31) resistive > touchscreen. This driver is probed by the MFD sunxi-gpadc-mfd. > > This driver uses ADC channels exposed through the IIO framework by > sunxi-gpadc-iio to get its

Re: [PATCH 4/5] input: touchscreen: support Allwinner SoCs' touchscreen

2016-07-20 Thread Jonathan Cameron
On 20/07/16 18:25, Dmitry Torokhov wrote: > Hi Quentin, > > On Wed, Jul 20, 2016 at 10:29:10AM +0200, Quentin Schulz wrote: >> This adds support for Allwinner SoCs' (A10, A13 and A31) resistive >> touchscreen. This driver is probed by the MFD sunxi-gpadc-mfd. >> >> This driver uses ADC channels ex

Re: [PATCH 4/5] input: touchscreen: support Allwinner SoCs' touchscreen

2016-07-20 Thread Dmitry Torokhov
Hi Quentin, On Wed, Jul 20, 2016 at 10:29:10AM +0200, Quentin Schulz wrote: > This adds support for Allwinner SoCs' (A10, A13 and A31) resistive > touchscreen. This driver is probed by the MFD sunxi-gpadc-mfd. > > This driver uses ADC channels exposed through the IIO framework by > sunxi-gpadc-ii

[PATCH 4/5] input: touchscreen: support Allwinner SoCs' touchscreen

2016-07-20 Thread Quentin Schulz
This adds support for Allwinner SoCs' (A10, A13 and A31) resistive touchscreen. This driver is probed by the MFD sunxi-gpadc-mfd. This driver uses ADC channels exposed through the IIO framework by sunxi-gpadc-iio to get its data. When opening this input device, it will start buffering in the ADC d