Re: [PATCH 4/5] gpio: xilinx: Utilize generic bitmap_get_value and _set_value

2021-01-05 Thread Michal Simek
Hi, +Srinivas, On 27. 12. 20 22:29, Linus Walleij wrote: > On Sat, Dec 26, 2020 at 7:44 AM Syed Nayyar Waris > wrote: > >> This patch reimplements the xgpio_set_multiple() function in >> drivers/gpio/gpio-xilinx.c to use the new generic functions: >> bitmap_get_value() and bitmap_set_value(). T

Re: [PATCH 4/5] gpio: xilinx: Utilize generic bitmap_get_value and _set_value

2020-12-27 Thread Linus Walleij
On Sat, Dec 26, 2020 at 7:44 AM Syed Nayyar Waris wrote: > This patch reimplements the xgpio_set_multiple() function in > drivers/gpio/gpio-xilinx.c to use the new generic functions: > bitmap_get_value() and bitmap_set_value(). The code is now simpler > to read and understand. Moreover, instead o

[PATCH 4/5] gpio: xilinx: Utilize generic bitmap_get_value and _set_value

2020-12-25 Thread Syed Nayyar Waris
This patch reimplements the xgpio_set_multiple() function in drivers/gpio/gpio-xilinx.c to use the new generic functions: bitmap_get_value() and bitmap_set_value(). The code is now simpler to read and understand. Moreover, instead of looping for each bit in xgpio_set_multiple() function, now we can