Re: [PATCH 4/4] x86: Pass kernel thread parameters in fork_frame

2016-05-23 Thread Brian Gerst
On Mon, May 23, 2016 at 11:36 AM, Andy Lutomirski wrote: > On Mon, May 23, 2016 at 8:23 AM, Josh Poimboeuf wrote: >> On Sat, May 21, 2016 at 12:04:51PM -0400, Brian Gerst wrote: >>> --- a/arch/x86/entry/entry_64.S >>> +++ b/arch/x86/entry/entry_64.S >>> @@ -405,37 +405,29 @@ END(__switch_to_asm)

Re: [PATCH 4/4] x86: Pass kernel thread parameters in fork_frame

2016-05-23 Thread Andy Lutomirski
On Mon, May 23, 2016 at 8:23 AM, Josh Poimboeuf wrote: > On Sat, May 21, 2016 at 12:04:51PM -0400, Brian Gerst wrote: >> --- a/arch/x86/entry/entry_64.S >> +++ b/arch/x86/entry/entry_64.S >> @@ -405,37 +405,29 @@ END(__switch_to_asm) >> * A newly forked process directly context switches into thi

Re: [PATCH 4/4] x86: Pass kernel thread parameters in fork_frame

2016-05-23 Thread Josh Poimboeuf
On Sat, May 21, 2016 at 12:04:51PM -0400, Brian Gerst wrote: > --- a/arch/x86/entry/entry_64.S > +++ b/arch/x86/entry/entry_64.S > @@ -405,37 +405,29 @@ END(__switch_to_asm) > * A newly forked process directly context switches into this address. > * > * rax: prev task we switched from > + * r

Re: [PATCH 4/4] x86: Pass kernel thread parameters in fork_frame

2016-05-22 Thread Brian Gerst
On Sun, May 22, 2016 at 2:01 PM, Andy Lutomirski wrote: > On Sat, May 21, 2016 at 9:04 AM, Brian Gerst wrote: >> Instead of setting up a fake pt_regs context, put the kernel thread >> function pointer and arg into the unused callee-restored registers >> of struct fork_frame. >> >> Signed-off-by:

Re: [PATCH 4/4] x86: Pass kernel thread parameters in fork_frame

2016-05-22 Thread Andy Lutomirski
On Sat, May 21, 2016 at 9:04 AM, Brian Gerst wrote: > Instead of setting up a fake pt_regs context, put the kernel thread > function pointer and arg into the unused callee-restored registers > of struct fork_frame. > > Signed-off-by: Brian Gerst Seems reasonable. Can you make sure you explicitl

[PATCH 4/4] x86: Pass kernel thread parameters in fork_frame

2016-05-21 Thread Brian Gerst
Instead of setting up a fake pt_regs context, put the kernel thread function pointer and arg into the unused callee-restored registers of struct fork_frame. Signed-off-by: Brian Gerst --- arch/x86/entry/entry_32.S| 28 +++- arch/x86/entry/entry_64.S| 30 ++