Re: [PATCH 4/4] ubifs: Implement new mount option, fscrypt_key_required

2019-03-15 Thread Richard Weinberger
Ted, Am Freitag, 15. März 2019, 14:51:28 CET schrieb Theodore Ts'o: > On Fri, Mar 15, 2019 at 08:48:10AM +0100, Richard Weinberger wrote: > > Ted, > > > > Am Freitag, 15. März 2019, 00:07:02 CET schrieb Theodore Ts'o: > > > Richard --- stepping back for a moment, in your use case, are you > > > a

Re: [PATCH 4/4] ubifs: Implement new mount option, fscrypt_key_required

2019-03-15 Thread Theodore Ts'o
On Fri, Mar 15, 2019 at 08:48:10AM +0100, Richard Weinberger wrote: > Ted, > > Am Freitag, 15. März 2019, 00:07:02 CET schrieb Theodore Ts'o: > > Richard --- stepping back for a moment, in your use case, are you > > assuming that the encryption key is always going to be present while > > the syste

Re: [PATCH 4/4] ubifs: Implement new mount option, fscrypt_key_required

2019-03-15 Thread Richard Weinberger
Ted, Am Freitag, 15. März 2019, 00:07:02 CET schrieb Theodore Ts'o: > Richard --- stepping back for a moment, in your use case, are you > assuming that the encryption key is always going to be present while > the system is running? it is not a hard requirement, it is something what is common on e

Re: [PATCH 4/4] ubifs: Implement new mount option, fscrypt_key_required

2019-03-14 Thread James Bottomley
On Thu, 2019-03-14 at 19:42 -0400, Theodore Ts'o wrote: > On Thu, Mar 14, 2019 at 04:15:11PM -0700, James Bottomley wrote: > > On Thu, 2019-03-14 at 18:15 +0100, Richard Weinberger wrote: > > > Usually fscrypt allows limited access to encrypted files even > > > if no key is available. > > > Encrypt

Re: [PATCH 4/4] ubifs: Implement new mount option, fscrypt_key_required

2019-03-14 Thread Theodore Ts'o
On Thu, Mar 14, 2019 at 04:15:11PM -0700, James Bottomley wrote: > On Thu, 2019-03-14 at 18:15 +0100, Richard Weinberger wrote: > > Usually fscrypt allows limited access to encrypted files even > > if no key is available. > > Encrypted filenames are shown and based on this names users > > can unlin

Re: [PATCH 4/4] ubifs: Implement new mount option, fscrypt_key_required

2019-03-14 Thread James Bottomley
On Thu, 2019-03-14 at 18:15 +0100, Richard Weinberger wrote: > Usually fscrypt allows limited access to encrypted files even > if no key is available. > Encrypted filenames are shown and based on this names users > can unlink and move files. Shouldn't they be able to read/write and create as well

Re: [PATCH 4/4] ubifs: Implement new mount option, fscrypt_key_required

2019-03-14 Thread Theodore Ts'o
Richard --- stepping back for a moment, in your use case, are you assuming that the encryption key is always going to be present while the system is running? Ubifs can't use dm-crypt, since it doesn't have a block device, but if you could, is much more like dm-crypt, in that you have the key *befo

Re: [PATCH 4/4] ubifs: Implement new mount option, fscrypt_key_required

2019-03-14 Thread Richard Weinberger
Eric, Am Donnerstag, 14. März 2019, 18:49:14 CET schrieb Eric Biggers: > Hi Richard, > > On Thu, Mar 14, 2019 at 06:15:59PM +0100, Richard Weinberger wrote: > > Usually fscrypt allows limited access to encrypted files even > > if no key is available. > > Encrypted filenames are shown and based on

Re: [PATCH 4/4] ubifs: Implement new mount option, fscrypt_key_required

2019-03-14 Thread Eric Biggers
Hi Richard, On Thu, Mar 14, 2019 at 06:15:59PM +0100, Richard Weinberger wrote: > Usually fscrypt allows limited access to encrypted files even > if no key is available. > Encrypted filenames are shown and based on this names users > can unlink and move files. Actually, fscrypt doesn't allow movi

[PATCH 4/4] ubifs: Implement new mount option, fscrypt_key_required

2019-03-14 Thread Richard Weinberger
Usually fscrypt allows limited access to encrypted files even if no key is available. Encrypted filenames are shown and based on this names users can unlink and move files. This is not always what people expect. The fscrypt_key_required mount option disables this feature. If no key is present all