Re: [PATCH 4/4] pinctrl/abx500: destroy mutex if returning early due to error

2013-01-31 Thread Lee Jones
On Thu, 31 Jan 2013, Stephen Warren wrote: > On 01/31/2013 01:01 AM, Lee Jones wrote: > > On Wed, 30 Jan 2013, Stephen Warren wrote: > > > >> On 01/30/2013 12:40 PM, Linus Walleij wrote: > >>> From: Lee Jones > >>> > >>> Current failure path neglects to mutex_destroy() before returning > >>> an

Re: [PATCH 4/4] pinctrl/abx500: destroy mutex if returning early due to error

2013-01-31 Thread Stephen Warren
On 01/31/2013 01:01 AM, Lee Jones wrote: > On Wed, 30 Jan 2013, Stephen Warren wrote: > >> On 01/30/2013 12:40 PM, Linus Walleij wrote: >>> From: Lee Jones >>> >>> Current failure path neglects to mutex_destroy() before returning >>> an error due to an invalid parameter or an error received from

Re: [PATCH 4/4] pinctrl/abx500: destroy mutex if returning early due to error

2013-01-31 Thread Lee Jones
On Wed, 30 Jan 2013, Stephen Warren wrote: > On 01/30/2013 12:40 PM, Linus Walleij wrote: > > From: Lee Jones > > > > Current failure path neglects to mutex_destroy() before returning > > an error due to an invalid parameter or an error received from > > gpiochip_add(). This patch aims to remedy

Re: [PATCH 4/4] pinctrl/abx500: destroy mutex if returning early due to error

2013-01-30 Thread Stephen Warren
On 01/30/2013 12:40 PM, Linus Walleij wrote: > From: Lee Jones > > Current failure path neglects to mutex_destroy() before returning > an error due to an invalid parameter or an error received from > gpiochip_add(). This patch aims to remedy that behaviour. > diff --git a/drivers/pinctrl/pinctrl

[PATCH 4/4] pinctrl/abx500: destroy mutex if returning early due to error

2013-01-30 Thread Linus Walleij
From: Lee Jones Current failure path neglects to mutex_destroy() before returning an error due to an invalid parameter or an error received from gpiochip_add(). This patch aims to remedy that behaviour. Signed-off-by: Lee Jones Signed-off-by: Linus Walleij --- drivers/pinctrl/pinctrl-abx500.c