Re: [PATCH 4/4] perf tools: Compare hists comm by addresses

2013-09-16 Thread Namhyung Kim
Hi Frederic, On Fri, 13 Sep 2013 15:59:49 +0200, Frederic Weisbecker wrote: > On Fri, Sep 13, 2013 at 05:07:06PM +0900, Namhyung Kim wrote: [SNIP] >> --- a/tools/perf/util/sort.c >> +++ b/tools/perf/util/sort.c >> @@ -1,5 +1,6 @@ >> #include "sort.h" >> #include "hist.h" >> +#include "comm.h"

Re: [PATCH 4/4] perf tools: Compare hists comm by addresses

2013-09-13 Thread Frederic Weisbecker
On Fri, Sep 13, 2013 at 05:07:06PM +0900, Namhyung Kim wrote: > Hi, > > On Thu, 12 Sep 2013 22:29:43 +0200, Frederic Weisbecker wrote: > > Now that comm strings are allocated only once and refcounted to be shared > > among threads, these can now be safely compared by addresses. This > > should rem

Re: [PATCH 4/4] perf tools: Compare hists comm by addresses

2013-09-13 Thread Namhyung Kim
Hi, On Thu, 12 Sep 2013 22:29:43 +0200, Frederic Weisbecker wrote: > Now that comm strings are allocated only once and refcounted to be shared > among threads, these can now be safely compared by addresses. This > should remove most hists collapses on post processing. [SNIP] > diff --git a/tools

[PATCH 4/4] perf tools: Compare hists comm by addresses

2013-09-12 Thread Frederic Weisbecker
Now that comm strings are allocated only once and refcounted to be shared among threads, these can now be safely compared by addresses. This should remove most hists collapses on post processing. Signed-off-by: Frederic Weisbecker Cc: Jiri Olsa Cc: David Ahern Cc: Ingo Molnar Cc: Namhyung Kim