Re: [PATCH 4/4] perf probe: Propagate error code when write(2) failed

2015-01-12 Thread Arnaldo Carvalho de Melo
Em Mon, Jan 12, 2015 at 08:17:52PM +0900, Masami Hiramatsu escreveu: > (2015/01/10 19:33), Namhyung Kim wrote: > > When it failed to write probe commands to the probe_event file in > > debugfs, it needs to propagate the error code properly. Current code > > blindly uses the return value of the wri

Re: [PATCH 4/4] perf probe: Propagate error code when write(2) failed

2015-01-12 Thread Masami Hiramatsu
(2015/01/10 19:33), Namhyung Kim wrote: > When it failed to write probe commands to the probe_event file in > debugfs, it needs to propagate the error code properly. Current code > blindly uses the return value of the write(2) so it always uses > -1 (-EPERM) and it might confuse users. > Good ca

[PATCH 4/4] perf probe: Propagate error code when write(2) failed

2015-01-10 Thread Namhyung Kim
When it failed to write probe commands to the probe_event file in debugfs, it needs to propagate the error code properly. Current code blindly uses the return value of the write(2) so it always uses -1 (-EPERM) and it might confuse users. Cc: Masami Hiramatsu Signed-off-by: Namhyung Kim --- to