Re: [PATCH 4/4] perf-probe: Warn if the target function is GNU Indirect function

2020-07-10 Thread Masami Hiramatsu
On Fri, 10 Jul 2020 08:55:40 -0300 Arnaldo Carvalho de Melo wrote: > Em Fri, Jul 10, 2020 at 12:30:08PM +0900, Masami Hiramatsu escreveu: > > On Thu, 9 Jul 2020 07:36:54 -0700 > > Andi Kleen wrote: > > > > > > diff --git a/tools/perf/util/probe-event.c > > > > b/tools/perf/util/probe-event.c >

Re: [PATCH 4/4] perf-probe: Warn if the target function is GNU Indirect function

2020-07-10 Thread Masami Hiramatsu
On Fri, 10 Jul 2020 16:45:12 +0530 Srikar Dronamraju wrote: > * Masami Hiramatsu [2020-07-09 17:07:31]: > > > Reported-by: Andi Kleen > > Signed-off-by: Masami Hiramatsu > > --- > > tools/perf/util/probe-event.c |5 + > > 1 file changed, 5 insertions(+) > > > > diff --git a/tools/pe

Re: [PATCH 4/4] perf-probe: Warn if the target function is GNU Indirect function

2020-07-10 Thread Arnaldo Carvalho de Melo
Em Fri, Jul 10, 2020 at 12:30:08PM +0900, Masami Hiramatsu escreveu: > On Thu, 9 Jul 2020 07:36:54 -0700 > Andi Kleen wrote: > > > > diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c > > > index 1e95a336862c..671176d39569 100644 > > > --- a/tools/perf/util/probe-event.c >

Re: [PATCH 4/4] perf-probe: Warn if the target function is GNU Indirect function

2020-07-10 Thread Srikar Dronamraju
* Masami Hiramatsu [2020-07-09 17:07:31]: > Reported-by: Andi Kleen > Signed-off-by: Masami Hiramatsu > --- > tools/perf/util/probe-event.c |5 + > 1 file changed, 5 insertions(+) > > diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c > index 1e95a336862c..6711

Re: [PATCH 4/4] perf-probe: Warn if the target function is GNU Indirect function

2020-07-09 Thread Masami Hiramatsu
On Thu, 9 Jul 2020 07:36:54 -0700 Andi Kleen wrote: > > diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c > > index 1e95a336862c..671176d39569 100644 > > --- a/tools/perf/util/probe-event.c > > +++ b/tools/perf/util/probe-event.c > > @@ -379,6 +379,11 @@ static int find_a

Re: [PATCH 4/4] perf-probe: Warn if the target function is GNU Indirect function

2020-07-09 Thread Andi Kleen
> diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c > index 1e95a336862c..671176d39569 100644 > --- a/tools/perf/util/probe-event.c > +++ b/tools/perf/util/probe-event.c > @@ -379,6 +379,11 @@ static int find_alternative_probe_point(struct debuginfo > *dinfo, >

[PATCH 4/4] perf-probe: Warn if the target function is GNU Indirect function

2020-07-09 Thread Masami Hiramatsu
Warn if the probe target function is GNU indirect function (GNU_IFUNC) because it may not what the user want to probe. The GNU indirect function ( https://sourceware.org/glibc/wiki/GNU_IFUNC ) is the dynamic solved symbol at runtime. IFUNC function is a selector which is invoked from the elf loade