Re: [PATCH 4/4] gcov: clang: pick GCC vs Clang format depending on compiler

2019-01-15 Thread Tri Vo
On Mon, Jan 14, 2019 at 5:25 PM Masahiro Yamada wrote: > > On Tue, Jan 15, 2019 at 6:07 AM Tri Vo wrote: > > > > Clang gcov format is only supported by Clang compiler, and Clang > > compiler only supports Clang format. > > > If so, what is the point of putting GCOV_FORMAT_CLANG into the > choice

Re: [PATCH 4/4] gcov: clang: pick GCC vs Clang format depending on compiler

2019-01-14 Thread Masahiro Yamada
On Tue, Jan 15, 2019 at 6:07 AM Tri Vo wrote: > > Clang gcov format is only supported by Clang compiler, and Clang > compiler only supports Clang format. If so, what is the point of putting GCOV_FORMAT_CLANG into the choice menu? You can choose the format only when you are using GCC. I think

Re: [PATCH 4/4] gcov: clang: pick GCC vs Clang format depending on compiler

2019-01-14 Thread Nick Desaulniers
On Mon, Jan 14, 2019 at 1:05 PM Tri Vo wrote: > > Clang gcov format is only supported by Clang compiler, and Clang > compiler only supports Clang format. > > We set gcov format to depend on which compiler (GCC or Clang) is used. > > Automatic format detection behavior is preserved because: > If GC

[PATCH 4/4] gcov: clang: pick GCC vs Clang format depending on compiler

2019-01-14 Thread Tri Vo
Clang gcov format is only supported by Clang compiler, and Clang compiler only supports Clang format. We set gcov format to depend on which compiler (GCC or Clang) is used. Automatic format detection behavior is preserved because: If GCC is used, one of the GCC gcov formats is selected. If Clang