Re: [PATCH 4/4] clk: zynq: Use of_init_clk_data()

2012-12-28 Thread Michal Simek
Stephen Boyd; Michal Simek >> > Cc: Soren Brinkmann; Mike Turquette; linux-kernel@vger.kernel.org; >> > linux-arm- >> > ker...@lists.infradead.org >> > Subject: Re: [PATCH 4/4] clk: zynq: Use of_init_clk_data() >> > >> > On W

Re: [PATCH 4/4] clk: zynq: Use of_init_clk_data()

2012-12-21 Thread Rob Herring
On 12/19/2012 02:54 PM, Stephen Boyd wrote: > On 12/19/12 12:30, Stephen Boyd wrote: >> On 12/19/12 11:22, Soren Brinkmann wrote: >>> Hi Stephen, >>> >>> I guess Josh is the better person to talk about this, since he created the >>> patches regarding common clock for mainline, but I tried running y

Re: [PATCH 4/4] clk: zynq: Use of_init_clk_data()

2012-12-21 Thread Josh Cartwright
nkmann; Mike Turquette; linux-kernel@vger.kernel.org; > > linux-arm- > > ker...@lists.infradead.org > > Subject: Re: [PATCH 4/4] clk: zynq: Use of_init_clk_data() > > > > On Wed, Dec 19, 2012 at 12:30:21PM -0800, Stephen Boyd wrote: > > > On 12/19/12 11:22, Soren B

RE: [PATCH 4/4] clk: zynq: Use of_init_clk_data()

2012-12-21 Thread Michal Simek
Subject: Re: [PATCH 4/4] clk: zynq: Use of_init_clk_data() > > On Wed, Dec 19, 2012 at 12:30:21PM -0800, Stephen Boyd wrote: > > On 12/19/12 11:22, Soren Brinkmann wrote: > [..] > > > > > > A probably unique thing I do is, I set the status of uart0 to > > &

Re: [PATCH 4/4] clk: zynq: Use of_init_clk_data()

2012-12-19 Thread Soren Brinkmann
On Wed, Dec 19, 2012 at 12:30:21PM -0800, Stephen Boyd wrote: > On 12/19/12 11:22, Soren Brinkmann wrote: > > Hi Stephen, > > > > I guess Josh is the better person to talk about this, since he created the > > patches regarding common clock for mainline, but I tried running your series > > and ran i

Re: [PATCH 4/4] clk: zynq: Use of_init_clk_data()

2012-12-19 Thread Stephen Boyd
On 12/19/12 12:30, Stephen Boyd wrote: > On 12/19/12 11:22, Soren Brinkmann wrote: >> Hi Stephen, >> >> I guess Josh is the better person to talk about this, since he created the >> patches regarding common clock for mainline, but I tried running your series >> and ran into this: >> >> Unable to ha

Re: [PATCH 4/4] clk: zynq: Use of_init_clk_data()

2012-12-19 Thread Josh Cartwright
On Wed, Dec 19, 2012 at 12:30:21PM -0800, Stephen Boyd wrote: > On 12/19/12 11:22, Soren Brinkmann wrote: [..] > > > > A probably unique thing I do is, I set the status of uart0 to disabled. > > This way > > I can reuse my rootfs which does not run getty on ttyPS1. And this worked > > fine > > be

Re: [PATCH 4/4] clk: zynq: Use of_init_clk_data()

2012-12-19 Thread Stephen Boyd
On 12/19/12 11:22, Soren Brinkmann wrote: > Hi Stephen, > > I guess Josh is the better person to talk about this, since he created the > patches regarding common clock for mainline, but I tried running your series > and ran into this: > > Unable to handle kernel NULL pointer dereference at virtual

Re: [PATCH 4/4] clk: zynq: Use of_init_clk_data()

2012-12-19 Thread Soren Brinkmann
Hi Stephen, I guess Josh is the better person to talk about this, since he created the patches regarding common clock for mainline, but I tried running your series and ran into this: Unable to handle kernel NULL pointer dereference at virtual address 002a pgd = c0004000 [002a] *pgd=00

Re: [PATCH 4/4] clk: zynq: Use of_init_clk_data()

2012-12-19 Thread Stephen Boyd
On 12/19/12 10:36, Josh Cartwright wrote: > On Wed, Dec 19, 2012 at 10:20:30AM -0800, Stephen Boyd wrote: >> On 12/19/12 09:26, Josh Cartwright wrote: >>> On Mon, Dec 17, 2012 at 01:02:15PM -0800, Stephen Boyd wrote: > [..] >> Can you show the code at those line numbers? There are quite a few >> WA

Re: [PATCH 4/4] clk: zynq: Use of_init_clk_data()

2012-12-19 Thread Josh Cartwright
On Wed, Dec 19, 2012 at 10:20:30AM -0800, Stephen Boyd wrote: > On 12/19/12 09:26, Josh Cartwright wrote: > > On Mon, Dec 17, 2012 at 01:02:15PM -0800, Stephen Boyd wrote: [..] > > Can you show the code at those line numbers? There are quite a few > WARN_ONs in that code and it's possible the WARN

Re: [PATCH 4/4] clk: zynq: Use of_init_clk_data()

2012-12-19 Thread Stephen Boyd
On 12/19/12 09:26, Josh Cartwright wrote: > On Mon, Dec 17, 2012 at 01:02:15PM -0800, Stephen Boyd wrote: >> Reduce lines of code and simplify this driver by using the >> generic clock binding parsing function. This also fixes a bug >> where the 'flags' member of the init struct is not initialized.

Re: [PATCH 4/4] clk: zynq: Use of_init_clk_data()

2012-12-19 Thread Josh Cartwright
On Mon, Dec 17, 2012 at 01:02:15PM -0800, Stephen Boyd wrote: > Reduce lines of code and simplify this driver by using the > generic clock binding parsing function. This also fixes a bug > where the 'flags' member of the init struct is not initialized. > > Signed-off-by: Stephen Boyd > Cc: Josh C

[PATCH 4/4] clk: zynq: Use of_init_clk_data()

2012-12-17 Thread Stephen Boyd
Reduce lines of code and simplify this driver by using the generic clock binding parsing function. This also fixes a bug where the 'flags' member of the init struct is not initialized. Signed-off-by: Stephen Boyd Cc: Josh Cartwright Cc: Soren Brinkmann --- drivers/clk/clk-zynq.c | 28 +