Re: [PATCH 4/4] clk: sifive: Refactor __prci_clock array by using macro

2020-11-04 Thread Zong Li
On Thu, Nov 5, 2020 at 10:50 AM Stephen Boyd wrote: > > Quoting Zong Li (2020-10-16 02:18:26) > > Refactor code by using DEFINE_PRCI_CLOCK to define each clock > > and reduce duplicate code. > > What is duplicate? Sorry for unclear description, actually, I want to say that we can remove the repea

Re: [PATCH 4/4] clk: sifive: Refactor __prci_clock array by using macro

2020-11-04 Thread Stephen Boyd
Quoting Zong Li (2020-10-16 02:18:26) > Refactor code by using DEFINE_PRCI_CLOCK to define each clock > and reduce duplicate code. What is duplicate? > > Signed-off-by: Zong Li > --- > drivers/clk/sifive/fu540-prci.c | 38 ++-- > drivers/clk/sifive/fu540-prci.h | 2 +- > drivers

[PATCH 4/4] clk: sifive: Refactor __prci_clock array by using macro

2020-10-16 Thread Zong Li
Refactor code by using DEFINE_PRCI_CLOCK to define each clock and reduce duplicate code. Signed-off-by: Zong Li --- drivers/clk/sifive/fu540-prci.c | 38 ++-- drivers/clk/sifive/fu540-prci.h | 2 +- drivers/clk/sifive/fu740-prci.c | 74 drivers/cl