Re: [PATCH 4/4] arm64/mm: Drop vm_fault_t argument from __do_page_fault()

2019-05-31 Thread Anshuman Khandual
On 05/29/2019 08:41 PM, Mark Rutland wrote: > On Wed, May 29, 2019 at 06:04:45PM +0530, Anshuman Khandual wrote: >> __do_page_fault() is over complicated with multiple goto statements. This >> cleans up code flow and while there drops the vm_fault_t argument. >> Signed-off-by: Anshuman Khandual

Re: [PATCH 4/4] arm64/mm: Drop vm_fault_t argument from __do_page_fault()

2019-05-31 Thread Anshuman Khandual
On 05/30/2019 12:04 PM, Christoph Hellwig wrote: > On Wed, May 29, 2019 at 06:04:45PM +0530, Anshuman Khandual wrote: >> __do_page_fault() is over complicated with multiple goto statements. This >> cleans up code flow and while there drops the vm_fault_t argument. > > There is no argument dropp

Re: [PATCH 4/4] arm64/mm: Drop vm_fault_t argument from __do_page_fault()

2019-05-29 Thread Christoph Hellwig
On Wed, May 29, 2019 at 06:04:45PM +0530, Anshuman Khandual wrote: > __do_page_fault() is over complicated with multiple goto statements. This > cleans up code flow and while there drops the vm_fault_t argument. There is no argument dropped anywhere, just a local variable.

Re: [PATCH 4/4] arm64/mm: Drop vm_fault_t argument from __do_page_fault()

2019-05-29 Thread Mark Rutland
On Wed, May 29, 2019 at 06:04:45PM +0530, Anshuman Khandual wrote: > __do_page_fault() is over complicated with multiple goto statements. This > cleans up code flow and while there drops the vm_fault_t argument. > Signed-off-by: Anshuman Khandual > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: M

[PATCH 4/4] arm64/mm: Drop vm_fault_t argument from __do_page_fault()

2019-05-29 Thread Anshuman Khandual
__do_page_fault() is over complicated with multiple goto statements. This cleans up code flow and while there drops the vm_fault_t argument. Signed-off-by: Anshuman Khandual Cc: Catalin Marinas Cc: Will Deacon Cc: Mark Rutland Cc: James Morse Cc: Andrey Konovalov --- arch/arm64/mm/fault.c