Re: [PATCH 4/4] NOMMU: Make it possible for RomFS to use MTD devices directly

2007-02-22 Thread David Howells
Andrew Morton <[EMAIL PROTECTED]> wrote: > > + brelse(bh); > > A little fyi: brelse() is rather old-fashioned, and has a usually unneeded > test for non-null bh in it. In situations where we know that the pointer is > valid, let's please use put_bh(). That's what was in the old romfs

Re: [PATCH 4/4] NOMMU: Make it possible for RomFS to use MTD devices directly

2007-02-21 Thread Andrew Morton
On Tue, 20 Feb 2007 19:51:06 + David Howells <[EMAIL PROTECTED]> wrote: > + brelse(bh); A little fyi: brelse() is rather old-fashioned, and has a usually unneeded test for non-null bh in it. In situations where we know that the pointer is valid, let's please use put_bh(). Anywa

[PATCH 4/4] NOMMU: Make it possible for RomFS to use MTD devices directly

2007-02-21 Thread David Howells
From: David Howells <[EMAIL PROTECTED]> Change RomFS so that it can use MTD devices directly - without the intercession of the block layer - as well as using block devices. This permits RomFS: (1) to use the MTD direct mapping facility available under NOMMU conditions if the underlying dev

[PATCH 4/4] NOMMU: Make it possible for RomFS to use MTD devices directly

2007-02-20 Thread David Howells
From: David Howells <[EMAIL PROTECTED]> Change RomFS so that it can use MTD devices directly - without the intercession of the block layer - as well as using block devices. This permits RomFS: (1) to use the MTD direct mapping facility available under NOMMU conditions if the underlying dev