* Dmitry Torokhov [210110 06:31]:
> I do not quite like that we need to keep this in remove(). I had the
> patch below for quite some time, could you please try it?
Yes seems to work nice :)
> Input: omap4-keypad - switch to use managed resources
>
> From: Dmitry Torokhov
>
> Now that input c
Hi Tony,
On Wed, Jan 06, 2021 at 02:58:22PM +0200, Tony Lindgren wrote:
> static int omap4_keypad_remove(struct platform_device *pdev)
> {
> struct omap4_keypad *keypad_data = platform_get_drvdata(pdev);
> - struct resource *res;
>
> dev_pm_clear_wake_irq(&pdev->dev);
> -
> -
* Sebastian Reichel [210106 13:44]:
> On Wed, Jan 06, 2021 at 02:58:22PM +0200, Tony Lindgren wrote:
> > - struct resource *res;
> >
> > dev_pm_clear_wake_irq(&pdev->dev);
> > -
> > - free_irq(keypad_data->irq, keypad_data);
> > -
> > pm_runtime_dont_use_autosuspend(&pdev->dev);
> >
Hi Tony,
I love your patch! Yet something to improve:
[auto build test ERROR on input/next]
[also build test ERROR on linus/master v5.11-rc2 next-20210104]
[cannot apply to hid/for-next linux/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch
Hi Tony,
On Wed, Jan 06, 2021 at 02:58:22PM +0200, Tony Lindgren wrote:
> Simplify probe with devm.
[...]
> /* input device allocation */
> - keypad_data->input = input_dev = input_allocate_device();
> + keypad_data->input = input_dev = devm_input_allocate_device(&pdev->dev);
>
Simplify probe with devm.
Cc: Arthur Demchenkov
Cc: Carl Philipp Klemm
Cc: Merlijn Wajer
Cc: Pavel Machek
Cc: ruleh
Cc: Sebastian Reichel
Signed-off-by: Tony Lindgren
---
drivers/input/keyboard/omap4-keypad.c | 81 ++-
1 file changed, 30 insertions(+), 51 deletions(
6 matches
Mail list logo
