Re: [PATCH 4/4] Fixup container_of() usage

2008-01-08 Thread Rusty Russell
On Tuesday 08 January 2008 19:46:29 Alexey Dobriyan wrote: > Using "attr" twice is not OK, because it effectively prohibits such > container_of() on variables not named "attr". > > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Thanks, nice catch. Took me a while to understand that you meant

[PATCH 4/4] Fixup container_of() usage

2008-01-08 Thread Alexey Dobriyan
Using "attr" twice is not OK, because it effectively prohibits such container_of() on variables not named "attr". Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> --- arch/sh/kernel/cpu/sh4/sq.c|2 +- drivers/lguest/lguest_device.c |2 +- 2 files changed, 2 insertions(+), 2 deletio