RE: [PATCH 4/4] Documentation: Add device tree bindings for Freescale FTM PWM

2013-09-02 Thread Xiubo Li-B47053
> Subject: Re: [PATCH 4/4] Documentation: Add device tree bindings for > Freescale FTM PWM > > On 08/30/2013 01:19 PM, Kumar Gala wrote: > > Should have at least something w/regards to a commit message. > > > > On Aug 20, 2013, at 10:07 PM, Xiubo Li wrote: &g

RE: [PATCH 4/4] Documentation: Add device tree bindings for Freescale FTM PWM

2013-09-01 Thread Xiubo Li-B47053
> Subject: Re: [PATCH 4/4] Documentation: Add device tree bindings for > Freescale FTM PWM > > Should have at least something w/regards to a commit message. > I have sent a V2 patch and have added it. > > + used to encode the polarity of PWM output. Set bit 0 of

Re: [PATCH 4/4] Documentation: Add device tree bindings for Freescale FTM PWM

2013-08-30 Thread Stephen Warren
On 08/30/2013 01:19 PM, Kumar Gala wrote: > Should have at least something w/regards to a commit message. > > On Aug 20, 2013, at 10:07 PM, Xiubo Li wrote: > >> Signed-off-by: Xiubo Li >> --- >> .../devicetree/bindings/pwm/fsl-ftm-pwm.txt| 52 >> ++ >> 1 file changed,

Re: [PATCH 4/4] Documentation: Add device tree bindings for Freescale FTM PWM

2013-08-30 Thread Kumar Gala
Should have at least something w/regards to a commit message. On Aug 20, 2013, at 10:07 PM, Xiubo Li wrote: > Signed-off-by: Xiubo Li > --- > .../devicetree/bindings/pwm/fsl-ftm-pwm.txt| 52 ++ > 1 file changed, 52 insertions(+) > create mode 100644 Documentation/devic

Re: [PATCH 4/4] Documentation: Add device tree bindings for Freescale FTM PWM

2013-08-26 Thread Stephen Warren
On 08/26/2013 09:48 PM, Xiubo Li-B47053 wrote: > Hi Stephen, > > >> Subject: Re: [PATCH 4/4] Documentation: Add device tree bindings for >> Freescale FTM PWM >> >> On 08/25/2013 11:35 PM, Xiubo Li-B47053 wrote: >>>> Subject: Re: [PATCH 4/4

RE: [PATCH 4/4] Documentation: Add device tree bindings for Freescale FTM PWM

2013-08-26 Thread Xiubo Li-B47053
Hi Stephen, > Subject: Re: [PATCH 4/4] Documentation: Add device tree bindings for > Freescale FTM PWM > > On 08/25/2013 11:35 PM, Xiubo Li-B47053 wrote: > >> Subject: Re: [PATCH 4/4] Documentation: Add device tree bindings for > ... > >>> Why do you need to

Re: [PATCH 4/4] Documentation: Add device tree bindings for Freescale FTM PWM

2013-08-26 Thread Stephen Warren
On 08/25/2013 11:35 PM, Xiubo Li-B47053 wrote: >> Subject: Re: [PATCH 4/4] Documentation: Add device tree bindings for ... >>> Why do you need to manipulate the pinctrl to en/disable a channel? >> >> This is because in Vybrid VF610 TOWER board, there are 4 leds, and each >> led's one point(diode's

RE: [PATCH 4/4] Documentation: Add device tree bindings for Freescale FTM PWM

2013-08-25 Thread Xiubo Li-B47053
Hi Thierry, > Subject: Re: [PATCH 4/4] Documentation: Add device tree bindings for > Freescale FTM PWM > > On Thu, Aug 22, 2013 at 08:26:10AM +0200, Sascha Hauer wrote: > > On Thu, Aug 22, 2013 at 02:55:42AM +, Xiubo Li-B47053 wrote: > > > Hi Tomasz, > >

RE: [PATCH 4/4] Documentation: Add device tree bindings for Freescale FTM PWM

2013-08-25 Thread Xiubo Li-B47053
Hi Stephen, > Subject: Re: [PATCH 4/4] Documentation: Add device tree bindings for > Freescale FTM PWM > > On 08/23/2013 01:36 AM, Thierry Reding wrote: > > On Thu, Aug 22, 2013 at 08:26:10AM +0200, Sascha Hauer wrote: > >> On Thu, Aug 22, 2013 at 02:55:42AM +

Re: [PATCH 4/4] Documentation: Add device tree bindings for Freescale FTM PWM

2013-08-23 Thread Stephen Warren
On 08/23/2013 03:10 AM, Thierry Reding wrote: > On Wed, Aug 21, 2013 at 11:07:42AM +0800, Xiubo Li wrote: >> Signed-off-by: Xiubo Li --- >> .../devicetree/bindings/pwm/fsl-ftm-pwm.txt| 52 >> ++ 1 file changed, 52 insertions(+) create >> mode 100644 >> Documentation/dev

Re: [PATCH 4/4] Documentation: Add device tree bindings for Freescale FTM PWM

2013-08-23 Thread Stephen Warren
On 08/23/2013 01:36 AM, Thierry Reding wrote: > On Thu, Aug 22, 2013 at 08:26:10AM +0200, Sascha Hauer wrote: >> On Thu, Aug 22, 2013 at 02:55:42AM +, Xiubo Li-B47053 wrote: >>> Hi Tomasz, >>> >>> Thanks for your comments. >>> >>> Could you explain meaning of this property more precisel

Re: [PATCH 4/4] Documentation: Add device tree bindings for Freescale FTM PWM

2013-08-23 Thread Thierry Reding
On Wed, Aug 21, 2013 at 11:07:42AM +0800, Xiubo Li wrote: > Signed-off-by: Xiubo Li > --- > .../devicetree/bindings/pwm/fsl-ftm-pwm.txt| 52 > ++ > 1 file changed, 52 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pwm/fsl-ftm-pwm.txt It used to

Re: [PATCH 4/4] Documentation: Add device tree bindings for Freescale FTM PWM

2013-08-23 Thread Thierry Reding
On Thu, Aug 22, 2013 at 10:25:30AM +0200, Tomasz Figa wrote: > On Thursday 22 of August 2013 02:55:42 Xiubo Li-B47053 wrote: > > Hi Tomasz, > > > > Thanks for your comments. > > > > > > +- #pwm-cells: Should be 3. Number of cells being used to specify > > > > PWM > > > > property. > > > > + Firs

Re: [PATCH 4/4] Documentation: Add device tree bindings for Freescale FTM PWM

2013-08-23 Thread Thierry Reding
On Thu, Aug 22, 2013 at 08:26:10AM +0200, Sascha Hauer wrote: > On Thu, Aug 22, 2013 at 02:55:42AM +, Xiubo Li-B47053 wrote: > > Hi Tomasz, > > > > Thanks for your comments. > > > > > > > Could you explain meaning of this property more precisely? I'm interested > > > especially how is this r

Re: [PATCH 4/4] Documentation: Add device tree bindings for Freescale FTM PWM

2013-08-22 Thread Tomasz Figa
On Thursday 22 of August 2013 09:52:42 Xiubo Li-B47053 wrote: > Hi Tomasz, > > > > > If the meaning of flags cell is the same as in generic, default PWM > > > > specifier format, then it should be noted here and generic PWM > > > > binding documentation mentioned. > > > > > > OK, How about the fo

RE: [PATCH 4/4] Documentation: Add device tree bindings for Freescale FTM PWM

2013-08-22 Thread Xiubo Li-B47053
Hi Tomasz, > > > If the meaning of flags cell is the same as in generic, default PWM > > > specifier format, then it should be noted here and generic PWM > > > binding documentation mentioned. > > > > OK, How about the following ? > > - #pwm-cells: Should be 3. See pwm.txt in this directory for

Re: [PATCH 4/4] Documentation: Add device tree bindings for Freescale FTM PWM

2013-08-22 Thread Tomasz Figa
On Thursday 22 of August 2013 02:55:42 Xiubo Li-B47053 wrote: > Hi Tomasz, > > Thanks for your comments. > > > > +- #pwm-cells: Should be 3. Number of cells being used to specify > > > PWM > > > property. > > > + First cell specifies the per-chip channel index of the PWM > > > to use, the > > >

RE: [PATCH 4/4] Documentation: Add device tree bindings for Freescale FTM PWM

2013-08-22 Thread Xiubo Li-B47053
Hi Sascha, > > > Could you explain meaning of this property more precisely? I'm > > > interested especially how is this related to the PWM IP block and > boards. > > > > > > > Yes. > > There are 8 channels most. While the pinctrls of 4th and 5th channels > > could be used by uart's Rx and Tx, then

Re: [PATCH 4/4] Documentation: Add device tree bindings for Freescale FTM PWM

2013-08-21 Thread Sascha Hauer
On Thu, Aug 22, 2013 at 02:55:42AM +, Xiubo Li-B47053 wrote: > Hi Tomasz, > > Thanks for your comments. > > > > Could you explain meaning of this property more precisely? I'm interested > > especially how is this related to the PWM IP block and boards. > > > > Yes. > There are 8 channels m

RE: [PATCH 4/4] Documentation: Add device tree bindings for Freescale FTM PWM

2013-08-21 Thread Xiubo Li-B47053
Hi Tomasz, Thanks for your comments. > > +- #pwm-cells: Should be 3. Number of cells being used to specify PWM > > property. > > + First cell specifies the per-chip channel index of the PWM > > to use, the > > + second cell is the period in nanoseconds and bit 0 in > > the third cell is > > +

Re: [PATCH 4/4] Documentation: Add device tree bindings for Freescale FTM PWM

2013-08-21 Thread Tomasz Figa
Hi Xiubo, Please see my comments inline. On Wednesday 21 of August 2013 11:07:42 Xiubo Li wrote: > Signed-off-by: Xiubo Li > --- > .../devicetree/bindings/pwm/fsl-ftm-pwm.txt| 52 > ++ 1 file changed, 52 insertions(+) > create mode 100644 > Documentation/devicetree/b

[PATCH 4/4] Documentation: Add device tree bindings for Freescale FTM PWM

2013-08-20 Thread Xiubo Li
Signed-off-by: Xiubo Li --- .../devicetree/bindings/pwm/fsl-ftm-pwm.txt| 52 ++ 1 file changed, 52 insertions(+) create mode 100644 Documentation/devicetree/bindings/pwm/fsl-ftm-pwm.txt diff --git a/Documentation/devicetree/bindings/pwm/fsl-ftm-pwm.txt b/Documentati