Re: [PATCH 4/11] eCryptfs: Replace encrypt, decrypt, and inode size write

2007-09-20 Thread Erez Zadok
In message <[EMAIL PROTECTED]>, Michael Halcrow writes: > On Wed, Sep 19, 2007 at 10:46:26PM -0700, Andrew Morton wrote: > (from ecryptfs_encrypt_page()): > > > + enc_extent_virt = kmalloc(PAGE_CACHE_SIZE, GFP_USER); > > > > I'd have thought that alloc_page() would be nicer. After all, we _are_ >

Re: [PATCH 4/11] eCryptfs: Replace encrypt, decrypt, and inode size write

2007-09-20 Thread Michael Halcrow
On Wed, Sep 19, 2007 at 10:46:26PM -0700, Andrew Morton wrote: (from ecryptfs_encrypt_page()): > > + enc_extent_virt = kmalloc(PAGE_CACHE_SIZE, GFP_USER); > > I'd have thought that alloc_page() would be nicer. After all, we _are_ > treating it as a page, and not as a random piece of memry. > >

Re: [PATCH 4/11] eCryptfs: Replace encrypt, decrypt, and inode size write

2007-09-19 Thread Andrew Morton
On Mon, 17 Sep 2007 16:47:10 -0500 Michael Halcrow <[EMAIL PROTECTED]> wrote: > Replace page encryption and decryption routines and inode size write > routine with versions that utilize the read_write.c functions. > > Signed-off-by: Michael Halcrow <[EMAIL PROTECTED]> > --- > fs/ecryptfs/crypto.

[PATCH 4/11] eCryptfs: Replace encrypt, decrypt, and inode size write

2007-09-17 Thread Michael Halcrow
Replace page encryption and decryption routines and inode size write routine with versions that utilize the read_write.c functions. Signed-off-by: Michael Halcrow <[EMAIL PROTECTED]> --- fs/ecryptfs/crypto.c | 427 ++-- fs/ecryptfs/ecryptfs_kernel.h |