Re: [PATCH 31/33] ASoC: max98088: use match_string() helper

2018-05-22 Thread Andy Shevchenko
On Tue, May 22, 2018 at 3:30 PM, Yisheng Xie wrote: > hmm, you mean something like: > > int ret; > > ret = match_string(eq_mode_name, ARRAY_SIZE(eq_mode_name), name); > if (ret < 0) /* Shouldn't happen */ > dev_err(component->dev, "Bad EQ channel name '%s'\

Re: [PATCH 31/33] ASoC: max98088: use match_string() helper

2018-05-22 Thread Yisheng Xie
Hi Andy, On 2018/5/22 6:24, Andy Shevchenko wrote: > On Mon, May 21, 2018 at 2:58 PM, Yisheng Xie wrote: >> match_string() returns the index of an array for a matching string, >> which can be used intead of open coded variant. > >> static int max98088_get_channel(struct snd_soc_component *compo

Re: [PATCH 31/33] ASoC: max98088: use match_string() helper

2018-05-21 Thread Andy Shevchenko
On Mon, May 21, 2018 at 2:58 PM, Yisheng Xie wrote: > match_string() returns the index of an array for a matching string, > which can be used intead of open coded variant. > static int max98088_get_channel(struct snd_soc_component *component, const > char *name) > { > + int ret = match_

[PATCH 31/33] ASoC: max98088: use match_string() helper

2018-05-21 Thread Yisheng Xie
match_string() returns the index of an array for a matching string, which can be used intead of open coded variant. Cc: Liam Girdwood Cc: Mark Brown Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: alsa-de...@alsa-project.org Signed-off-by: Yisheng Xie --- sound/soc/codecs/max98088.c | 9 +++--