Re: [PATCH 3.13 35/99] tty: Set correct tty name in active sysfs attribute

2014-02-24 Thread Hannes Reinecke
On 02/23/2014 04:05 PM, David Herrmann wrote: > Hi > > On Sun, Feb 23, 2014 at 1:20 AM, Ray Strode wrote: >> Hi, >> >> >> On Feb 22, 2014 9:27 AM, "David Herrmann" wrote: >>> How about this: >>> >>> + driver = cs[i]->device(cs[i], &index); >>> +/* special case for t

Re: [PATCH 3.13 35/99] tty: Set correct tty name in active sysfs attribute

2014-02-23 Thread David Herrmann
Hi On Sun, Feb 23, 2014 at 1:20 AM, Ray Strode wrote: > Hi, > > > On Feb 22, 2014 9:27 AM, "David Herrmann" wrote: >> How about this: >> >> + driver = cs[i]->device(cs[i], &index); >> +/* special case for tty0 which must not be resolved */ >> + if (dri

Re: [PATCH 3.13 35/99] tty: Set correct tty name in active sysfs attribute

2014-02-23 Thread Ray Strode
Hi, On Sat, Feb 22, 2014 at 10:16 AM, Hannes Reinecke wrote: > And of course, checking for "!tty0" is the proper check for serial console. > Which, of course, means we have to stay with a broken kernel interface for > ever and ever. > > Innovation, here we come. So just so we're clear: 1) you ha

Re: [PATCH 3.13 35/99] tty: Set correct tty name in active sysfs attribute

2014-02-22 Thread Ray Strode
Hi, (resending because my phone tried to send the reply as html mail and it got rejected) On Sat, Feb 22, 2014 at 9:27 AM, David Herrmann wrote: > > How about this: > > + driver = cs[i]->device(cs[i], &index); > +/* special case for tty0 which must not be resolved *

Re: [PATCH 3.13 35/99] tty: Set correct tty name in active sysfs attribute

2014-02-22 Thread David Herrmann
Hi On Sat, Feb 22, 2014 at 4:16 PM, Hannes Reinecke wrote: > On 02/21/2014 11:18 PM, Ray Strode wrote: >> >> Hi, >> >> On Fri, Feb 21, 2014 at 3:21 PM, Greg Kroah-Hartman >> wrote: >>> >>> Ray, Josh, can I get some more information about this? Is this broken >>> in Linus's tree? Or did I get t

Re: [PATCH 3.13 35/99] tty: Set correct tty name in active sysfs attribute

2014-02-22 Thread Peter Hurley
On 02/22/2014 08:25 AM, David Herrmann wrote: Hi On Fri, Feb 21, 2014 at 11:53 PM, Ray Strode wrote: Hi, On Fri, Feb 21, 2014 at 11:01 AM, Kay Sievers wrote: Why did the tty0 change to tty1 now? That doesn't look like a "driver name" vs. "device name" issue? I don't know if it's intention

Re: [PATCH 3.13 35/99] tty: Set correct tty name in active sysfs attribute

2014-02-22 Thread David Herrmann
Hi On Fri, Feb 21, 2014 at 11:53 PM, Ray Strode wrote: > Hi, > > On Fri, Feb 21, 2014 at 11:01 AM, Kay Sievers wrote: >> Why did the tty0 change to tty1 now? That doesn't look like a "driver >> name" vs. "device name" issue? > > I don't know if it's intentional, but the patch does: > +

Re: [PATCH 3.13 35/99] tty: Set correct tty name in active sysfs attribute

2014-02-22 Thread Hannes Reinecke
On 02/21/2014 11:18 PM, Ray Strode wrote: Hi, On Fri, Feb 21, 2014 at 3:21 PM, Greg Kroah-Hartman wrote: Ray, Josh, can I get some more information about this? Is this broken in Linus's tree? Or did I get the backport wrong here? I don't think it's a problem with the backport specifically.

Re: [PATCH 3.13 35/99] tty: Set correct tty name in active sysfs attribute

2014-02-21 Thread Ray Strode
Hi, On Fri, Feb 21, 2014 at 11:01 AM, Kay Sievers wrote: > Why did the tty0 change to tty1 now? That doesn't look like a "driver > name" vs. "device name" issue? I don't know if it's intentional, but the patch does: + int index = cs[i]->index; ... + driver = cs[i]->de

Re: [PATCH 3.13 35/99] tty: Set correct tty name in active sysfs attribute

2014-02-21 Thread Ray Strode
Hi, On Fri, Feb 21, 2014 at 3:21 PM, Greg Kroah-Hartman wrote: > Ray, Josh, can I get some more information about this? Is this broken > in Linus's tree? Or did I get the backport wrong here? I don't think it's a problem with the backport specifically. To be honest, i'm not even 100% sure it is

Re: [PATCH 3.13 35/99] tty: Set correct tty name in active sysfs attribute

2014-02-21 Thread Greg Kroah-Hartman
On Fri, Feb 21, 2014 at 09:48:46AM -0500, Josh Boyer wrote: > On Thu, Feb 20, 2014 at 6:52 PM, Greg Kroah-Hartman > wrote: > > 3.13-stable review patch. If anyone has any objections, please let me know. > > > > -- > > > > From: Hannes Reinecke > > > > commit d8a5dc3033af2fd6d1603

Re: [PATCH 3.13 35/99] tty: Set correct tty name in active sysfs attribute

2014-02-21 Thread Kay Sievers
On Fri, Feb 21, 2014 at 3:56 PM, Josh Boyer wrote: > On Fri, Feb 21, 2014 at 9:52 AM, Hannes Reinecke wrote: >> On 02/21/2014 03:48 PM, Josh Boyer wrote: >>> On Thu, Feb 20, 2014 at 6:52 PM, Greg Kroah-Hartman >>> wrote: 3.13-stable review patch. If anyone has any objections, please let me

Re: [PATCH 3.13 35/99] tty: Set correct tty name in active sysfs attribute

2014-02-21 Thread Greg Kroah-Hartman
On Fri, Feb 21, 2014 at 03:52:44PM +0100, Hannes Reinecke wrote: > On 02/21/2014 03:48 PM, Josh Boyer wrote: > > On Thu, Feb 20, 2014 at 6:52 PM, Greg Kroah-Hartman > > wrote: > >> 3.13-stable review patch. If anyone has any objections, please let me > >> know. > >> > >> -- > >>

Re: [PATCH 3.13 35/99] tty: Set correct tty name in active sysfs attribute

2014-02-21 Thread Peter Hurley
On 02/21/2014 09:52 AM, Hannes Reinecke wrote: On 02/21/2014 03:48 PM, Josh Boyer wrote: On Thu, Feb 20, 2014 at 6:52 PM, Greg Kroah-Hartman wrote: 3.13-stable review patch. If anyone has any objections, please let me know. -- From: Hannes Reinecke commit d8a5dc3033af2fd6d

Re: [PATCH 3.13 35/99] tty: Set correct tty name in active sysfs attribute

2014-02-21 Thread Josh Boyer
On Fri, Feb 21, 2014 at 9:52 AM, Hannes Reinecke wrote: > On 02/21/2014 03:48 PM, Josh Boyer wrote: >> On Thu, Feb 20, 2014 at 6:52 PM, Greg Kroah-Hartman >> wrote: >>> 3.13-stable review patch. If anyone has any objections, please let me know. >>> >>> -- >>> >>> From: Hannes Rei

Re: [PATCH 3.13 35/99] tty: Set correct tty name in active sysfs attribute

2014-02-21 Thread Hannes Reinecke
On 02/21/2014 03:48 PM, Josh Boyer wrote: > On Thu, Feb 20, 2014 at 6:52 PM, Greg Kroah-Hartman > wrote: >> 3.13-stable review patch. If anyone has any objections, please let me know. >> >> -- >> >> From: Hannes Reinecke >> >> commit d8a5dc3033af2fd6d16030d2ee4fbd073460fe54 upstr

Re: [PATCH 3.13 35/99] tty: Set correct tty name in active sysfs attribute

2014-02-21 Thread Josh Boyer
On Thu, Feb 20, 2014 at 6:52 PM, Greg Kroah-Hartman wrote: > 3.13-stable review patch. If anyone has any objections, please let me know. > > -- > > From: Hannes Reinecke > > commit d8a5dc3033af2fd6d16030d2ee4fbd073460fe54 upstream. > > The 'active' sysfs attribute should refer to

[PATCH 3.13 35/99] tty: Set correct tty name in active sysfs attribute

2014-02-20 Thread Greg Kroah-Hartman
3.13-stable review patch. If anyone has any objections, please let me know. -- From: Hannes Reinecke commit d8a5dc3033af2fd6d16030d2ee4fbd073460fe54 upstream. The 'active' sysfs attribute should refer to the currently active tty devices the console is running on, not the curre