Re: [PATCH 3.10 268/268] mm: larger stack guard gap, between vmas

2017-06-21 Thread Willy Tarreau
Hey Hugh, On Wed, Jun 21, 2017 at 09:18:23AM +0200, Willy Tarreau wrote: > Thanks a lot, I'll include your patch and will test it again. And > yes, I intend to merge Helge's fix once it lands into mainline (maybe > it is right now, I didn't check) and possibly other ones you might be > working on

Re: [PATCH 3.10 268/268] mm: larger stack guard gap, between vmas

2017-06-21 Thread Willy Tarreau
On Wed, Jun 21, 2017 at 12:05:07AM -0700, Hugh Dickins wrote: > On Mon, 19 Jun 2017, Willy Tarreau wrote: > > > From: Hugh Dickins > > > > commit 1be7107fbe18eed3e319a6c3e83c78254b693acb upstream. > > Some of these suggested adjustments below are just what comparing mine > and yours showed up,

Re: [PATCH 3.10 268/268] mm: larger stack guard gap, between vmas

2017-06-21 Thread Hugh Dickins
On Mon, 19 Jun 2017, Willy Tarreau wrote: > From: Hugh Dickins > > commit 1be7107fbe18eed3e319a6c3e83c78254b693acb upstream. Some of these suggested adjustments below are just what comparing mine and yours showed up, and I'm being anal in passing them on e.g. I do like your blank line in mm.h,

[PATCH 3.10 268/268] mm: larger stack guard gap, between vmas

2017-06-19 Thread Willy Tarreau
From: Hugh Dickins commit 1be7107fbe18eed3e319a6c3e83c78254b693acb upstream. Stack guard page is a useful feature to reduce a risk of stack smashing into a different mapping. We have been using a single page gap which is sufficient to prevent having stack adjacent to a different mapping. But thi