Re: [PATCH 3/9] perf tools: Account entry stats when it's added to the output tree

On Tue, 22 Apr 2014 19:10:49 +0200, Jiri Olsa wrote: > On Tue, Apr 22, 2014 at 05:49:45PM +0900, Namhyung Kim wrote: > > SNIP > >> >> diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c >> index 1c77714f668d..f955ae5a41c5 100644 >> --- a/tools/perf/util/hist.c >> +++ b/tools/perf/util/hi

Re: [PATCH 3/9] perf tools: Account entry stats when it's added to the output tree

On Tue, 22 Apr 2014 16:54:49 +0200, Jiri Olsa wrote: > On Tue, Apr 22, 2014 at 05:49:45PM +0900, Namhyung Kim wrote: > > SNIP > >> } >> >> static int process_sample_event(struct perf_tool *tool, >> @@ -234,19 +230,17 @@ static int __cmd_annotate(struct perf_annotate *ann) >> total_nr_sampl

Re: [PATCH 3/9] perf tools: Account entry stats when it's added to the output tree

On Tue, Apr 22, 2014 at 05:49:45PM +0900, Namhyung Kim wrote: SNIP > > diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c > index 1c77714f668d..f955ae5a41c5 100644 > --- a/tools/perf/util/hist.c > +++ b/tools/perf/util/hist.c > @@ -344,9 +344,11 @@ void hists__inc_nr_entries(struct hi

Re: [PATCH 3/9] perf tools: Account entry stats when it's added to the output tree

On Tue, Apr 22, 2014 at 05:49:45PM +0900, Namhyung Kim wrote: SNIP > } > > static int process_sample_event(struct perf_tool *tool, > @@ -234,19 +230,17 @@ static int __cmd_annotate(struct perf_annotate *ann) > total_nr_samples = 0; > evlist__for_each(session->evlist, pos) { >

[PATCH 3/9] perf tools: Account entry stats when it's added to the output tree

Currently, accounting each sample is done in multiple places - once when adding them to the input tree, other when adding them to the output tree. It's not only confusing but also can cause a subtle problem since concurrent processing like in perf top might see the updated stats before adding entr