Re: [PATCH 3/9] fs/ext4: Disallow encryption if inode is DAX

2020-05-20 Thread Jan Kara
On Tue 19-05-20 19:02:33, Ira Weiny wrote: > On Mon, May 18, 2020 at 09:24:47AM -0700, Eric Biggers wrote: > > On Sun, May 17, 2020 at 10:03:15PM -0700, Ira Weiny wrote: > > First off... OMG... > > I'm seeing some possible user pitfalls which are complicating things IMO. It > probably does not

Re: [PATCH 3/9] fs/ext4: Disallow encryption if inode is DAX

2020-05-19 Thread Ira Weiny
On Mon, May 18, 2020 at 09:24:47AM -0700, Eric Biggers wrote: > On Sun, May 17, 2020 at 10:03:15PM -0700, Ira Weiny wrote: First off... OMG... I'm seeing some possible user pitfalls which are complicating things IMO. It probably does not matter because most users don't care and have either enab

Re: [PATCH 3/9] fs/ext4: Disallow encryption if inode is DAX

2020-05-18 Thread Eric Biggers
On Mon, May 18, 2020 at 12:23:57PM -0700, Ira Weiny wrote: > > > > The other question is what should happen when a file is created in an > > encrypted > > directory when the filesystem is mounted with -o dax. Actually, I think I > > missed something there. Currently (based on reading the code)

Re: [PATCH 3/9] fs/ext4: Disallow encryption if inode is DAX

2020-05-18 Thread Ira Weiny
On Mon, May 18, 2020 at 09:24:47AM -0700, Eric Biggers wrote: > On Sun, May 17, 2020 at 10:03:15PM -0700, Ira Weiny wrote: > > On Fri, May 15, 2020 at 07:02:53PM -0700, Eric Biggers wrote: > > > On Tue, May 12, 2020 at 10:43:18PM -0700, ira.we...@intel.com wrote: > > > > From: Ira Weiny > > > > >

Re: [PATCH 3/9] fs/ext4: Disallow encryption if inode is DAX

2020-05-18 Thread Eric Biggers
On Sun, May 17, 2020 at 10:03:15PM -0700, Ira Weiny wrote: > On Fri, May 15, 2020 at 07:02:53PM -0700, Eric Biggers wrote: > > On Tue, May 12, 2020 at 10:43:18PM -0700, ira.we...@intel.com wrote: > > > From: Ira Weiny > > > > > > Encryption and DAX are incompatible. Changing the DAX mode due to

Re: [PATCH 3/9] fs/ext4: Disallow encryption if inode is DAX

2020-05-17 Thread Ira Weiny
On Fri, May 15, 2020 at 07:02:53PM -0700, Eric Biggers wrote: > On Tue, May 12, 2020 at 10:43:18PM -0700, ira.we...@intel.com wrote: > > From: Ira Weiny > > > > Encryption and DAX are incompatible. Changing the DAX mode due to a > > change in Encryption mode is wrong without a corresponding > >

Re: [PATCH 3/9] fs/ext4: Disallow encryption if inode is DAX

2020-05-15 Thread Eric Biggers
On Tue, May 12, 2020 at 10:43:18PM -0700, ira.we...@intel.com wrote: > From: Ira Weiny > > Encryption and DAX are incompatible. Changing the DAX mode due to a > change in Encryption mode is wrong without a corresponding > address_space_operations update. > > Make the 2 options mutually exclusiv

[PATCH 3/9] fs/ext4: Disallow encryption if inode is DAX

2020-05-12 Thread ira . weiny
From: Ira Weiny Encryption and DAX are incompatible. Changing the DAX mode due to a change in Encryption mode is wrong without a corresponding address_space_operations update. Make the 2 options mutually exclusive by returning an error if DAX was set first. Furthermore, clarify the documentati