Re: [PATCH 3/8] riscv: init: merge split string literals in preprocessor directive

2019-10-17 Thread Paul Walmsley
On Fri, 18 Oct 2019, Luc Van Oostenryck wrote: > I quickly checked and gcc also complain about the second line: > $ cat y.c > #ifndef __riscv_cmodel_medany > #error "setup_vm() is called from head.S before relocate so it should " >"not use absolute addressing." > #endif > > $

Re: [PATCH 3/8] riscv: init: merge split string literals in preprocessor directive

2019-10-17 Thread Luc Van Oostenryck
On Thu, Oct 17, 2019 at 09:38:18PM -0700, Paul Walmsley wrote: > On Fri, 18 Oct 2019, Luc Van Oostenryck wrote: > > > On Thu, Oct 17, 2019 at 05:49:24PM -0700, Paul Walmsley wrote: > > > sparse complains loudly when string literals associated with > > > preprocessor directives are split into multi

Re: [PATCH 3/8] riscv: init: merge split string literals in preprocessor directive

2019-10-17 Thread Luc Van Oostenryck
On Thu, Oct 17, 2019 at 09:38:18PM -0700, Paul Walmsley wrote: > On Fri, 18 Oct 2019, Luc Van Oostenryck wrote: > > > On Thu, Oct 17, 2019 at 05:49:24PM -0700, Paul Walmsley wrote: > > > sparse complains loudly when string literals associated with > > > preprocessor directives are split into multi

Re: [PATCH 3/8] riscv: init: merge split string literals in preprocessor directive

2019-10-17 Thread Luc Van Oostenryck
On Thu, Oct 17, 2019 at 05:49:24PM -0700, Paul Walmsley wrote: > sparse complains loudly when string literals associated with > preprocessor directives are split into multiple, separately quoted > strings across different lines: ... > #ifndef __riscv_cmodel_medany > -#error "setup_vm() is calle

Re: [PATCH 3/8] riscv: init: merge split string literals in preprocessor directive

2019-10-17 Thread Paul Walmsley
On Fri, 18 Oct 2019, Luc Van Oostenryck wrote: > On Thu, Oct 17, 2019 at 05:49:24PM -0700, Paul Walmsley wrote: > > sparse complains loudly when string literals associated with > > preprocessor directives are split into multiple, separately quoted > > strings across different lines: > > ... > >

[PATCH 3/8] riscv: init: merge split string literals in preprocessor directive

2019-10-17 Thread Paul Walmsley
sparse complains loudly when string literals associated with preprocessor directives are split into multiple, separately quoted strings across different lines: arch/riscv/mm/init.c:341:9: error: Expected ; at the end of type declaration arch/riscv/mm/init.c:341:9: error: got "not use absolute addr