RE: [PATCH 3/8] iio: Add support for DA9150 GPADC

2014-10-15 Thread Opensource [Adam Thomson]
On October 11, 2014 23:48, Hartmut Knaack wrote: > Hi, > I have put a few comments inline. > > Adam Thomson schrieb am 23.09.2014 12:53: > > This patch adds support for DA9150 Charger & Fuel-Gauge IC GPADC. > > > > Signed-off-by: Adam Thomson > > --- > > drivers/iio/adc/Kconfig| 9 + >

Re: [PATCH 3/8] iio: Add support for DA9150 GPADC

2014-10-11 Thread Hartmut Knaack
Hi, I have put a few comments inline. Adam Thomson schrieb am 23.09.2014 12:53: > This patch adds support for DA9150 Charger & Fuel-Gauge IC GPADC. > > Signed-off-by: Adam Thomson > --- > drivers/iio/adc/Kconfig| 9 + > drivers/iio/adc/Makefile | 1 + > drivers/iio/adc/da9150-

RE: [PATCH 3/8] iio: Add support for DA9150 GPADC

2014-10-09 Thread Opensource [Adam Thomson]
On October 7, 2014 20:37, Jonathan Cameron wrote: > On October 7, 2014 3:55:55 PM GMT+01:00, "Opensource [Adam Thomson]" > wrote: > >On September 27, 2014 11:50, Jonathan Cameron wrote: > > > >> On 23/09/14 11:53, Adam Thomson wrote: > >> > This patch adds support for DA9150 Charger & Fuel-Gauge

RE: [PATCH 3/8] iio: Add support for DA9150 GPADC

2014-10-07 Thread Jonathan Cameron
On October 7, 2014 3:55:55 PM GMT+01:00, "Opensource [Adam Thomson]" wrote: >On September 27, 2014 11:50, Jonathan Cameron wrote: > >> On 23/09/14 11:53, Adam Thomson wrote: >> > This patch adds support for DA9150 Charger & Fuel-Gauge IC GPADC. > >> > + >> > +static inline int da9150_gpadc_gpio

RE: [PATCH 3/8] iio: Add support for DA9150 GPADC

2014-10-07 Thread Opensource [Adam Thomson]
On September 27, 2014 11:50, Jonathan Cameron wrote: > On 23/09/14 11:53, Adam Thomson wrote: > > This patch adds support for DA9150 Charger & Fuel-Gauge IC GPADC. > > + > > +static inline int da9150_gpadc_gpio_6v_voltage_now(int raw_val) > > +{ > > + /* Convert to mV */ > > + return (6 * ((r

Re: [PATCH 3/8] iio: Add support for DA9150 GPADC

2014-09-27 Thread Jonathan Cameron
On 23/09/14 11:53, Adam Thomson wrote: > This patch adds support for DA9150 Charger & Fuel-Gauge IC GPADC. > > Signed-off-by: Adam Thomson Very nearly there although I still would prefer all channels to use (raw + offset) * scale and let userspace or in kernel conversion functions handle it. > --

[PATCH 3/8] iio: Add support for DA9150 GPADC

2014-09-23 Thread Adam Thomson
This patch adds support for DA9150 Charger & Fuel-Gauge IC GPADC. Signed-off-by: Adam Thomson --- drivers/iio/adc/Kconfig| 9 + drivers/iio/adc/Makefile | 1 + drivers/iio/adc/da9150-gpadc.c | 406 + 3 files changed, 416 insertions(+) cr