Re: [PATCH 3/8] ext3: remove lock/unlock super

2012-08-18 Thread Marco Stornelli
Il 18/08/2012 01:08, Theodore Ts'o ha scritto: On Fri, Aug 17, 2012 at 08:47:04AM +0200, Marco Stornelli wrote: Great. I'll remove the calls for ext3/ext4 when I'll submit the second version of the patch. FYI, I have the following patch my ext4 tree, so I could do more intensive testing. I'll

Re: [PATCH 3/8] ext3: remove lock/unlock super

2012-08-17 Thread Theodore Ts'o
On Fri, Aug 17, 2012 at 08:47:04AM +0200, Marco Stornelli wrote: > Great. I'll remove the calls for ext3/ext4 when I'll submit the > second version of the patch. FYI, I have the following patch my ext4 tree, so I could do more intensive testing. I'll let folks know if anything goes horribly wrong

Re: [PATCH 3/8] ext3: remove lock/unlock super

2012-08-16 Thread Marco Stornelli
Il 16/08/2012 21:19, Theodore Ts'o ha scritto: On Thu, Aug 16, 2012 at 06:39:04PM +0200, Jan Kara wrote: On Thu 16-08-12 12:00:26, Marco Stornelli wrote: From: Marco Stornelli Replaced lock and unlock super with a new fs mutex s_lock. Hum, is the lock needed at all? Remount & unfreeze bot

Re: [PATCH 3/8] ext3: remove lock/unlock super

2012-08-16 Thread Theodore Ts'o
On Thu, Aug 16, 2012 at 06:39:04PM +0200, Jan Kara wrote: > On Thu 16-08-12 12:00:26, Marco Stornelli wrote: > > From: Marco Stornelli > > > > Replaced lock and unlock super with a new fs mutex s_lock. > Hum, is the lock needed at all? Remount & unfreeze both run with s_umount > held for writin

Re: [PATCH 3/8] ext3: remove lock/unlock super

2012-08-16 Thread Jan Kara
On Thu 16-08-12 12:00:26, Marco Stornelli wrote: > From: Marco Stornelli > > Replaced lock and unlock super with a new fs mutex s_lock. Hum, is the lock needed at all? Remount & unfreeze both run with s_umount held for writing. Thus we already have exclusion between these two calls. The same se

[PATCH 3/8] ext3: remove lock/unlock super

2012-08-16 Thread Marco Stornelli
From: Marco Stornelli Replaced lock and unlock super with a new fs mutex s_lock. Signed-off-by: Marco Stornelli --- diff -Nurp linux-3.6-rc1-orig/fs/ext3/ext3.h linux-3.6-rc1/fs/ext3/ext3.h --- linux-3.6-rc1-orig/fs/ext3/ext3.h 2012-08-16 09:37:31.0 +0200 +++ linux-3.6-rc1/fs/ext3/ex