Re: [PATCH 3/8] FMC: add core bus driver

2013-06-18 Thread Alessandro Rubini
> Alessandro, care to respin the patches that I didn't apply and resend > them so that I can? Yes, ASAP. But, according to the later message by David, I'll respin with the BSD license for demo code and EXPORT_SYMBOL (no GPL-only clause): https://lkml.org/lkml/2013/6/18/119 "As mentioned, CER

Re: [PATCH 3/8] FMC: add core bus driver

2013-06-18 Thread Greg KH
On Tue, Jun 18, 2013 at 09:30:00AM +0200, Juan David Gonzalez Cobas wrote: > Hi all, > > On Tue, Jun 18, 2013 at 1:38 AM, Alessandro Rubini wrote: > > [...] > >   > > Yes, it was intended. I don't think it's an issue for merging, but > I understand you've seen so many such undesire

Re: [PATCH 3/8] FMC: add core bus driver

2013-06-18 Thread Juan David Gonzalez Cobas
On Tue, Jun 18, 2013 at 1:38 AM, Alessandro Rubini wrote: >>> + * Released according to the GNU GPL, version 2 or any later version. [...] > I think we want to allow for proprietary FMC drivers. I personally > don't feel this is a core kernel technology. But I'll let David Cobas > expand on CERN

Re: [PATCH 3/8] FMC: add core bus driver

2013-06-17 Thread Alessandro Rubini
>> + * Released according to the GNU GPL, version 2 or any later version. > > I have to ask, do you really mean "or any later version"? Yes, it was intended. I don't think it's an issue for merging, but I understand you've seen so many such undesired copy-paste errors. >> +EXPORT_SYMBOL(fmc_driv

Re: [PATCH 3/8] FMC: add core bus driver

2013-06-17 Thread Greg KH
On Wed, Jun 12, 2013 at 09:13:47AM +0200, Alessandro Rubini wrote: > --- a/drivers/fmc/fmc-core.c > +++ b/drivers/fmc/fmc-core.c > @@ -1,13 +1,285 @@ > -/* Temporary placeholder so the empty code can build */ > +/* > + * Copyright (C) 2012 CERN (www.cern.ch) > + * Author: Alessandro Rubini > + * >

Re: [PATCH 3/8] FMC: add core bus driver

2013-06-17 Thread Greg KH
On Wed, Jun 12, 2013 at 09:13:47AM +0200, Alessandro Rubini wrote: > +static void fmc_release(struct device *dev) > +{ > + struct fmc_device *fmc = container_of(dev, struct fmc_device, dev); > + > + kfree(fmc); > +} I read so many people who write new bus / device code that get this wrong,

[PATCH 3/8] FMC: add core bus driver

2013-06-12 Thread Alessandro Rubini
This module offers registration services for both carriers (i.e. devices) and mezzanines (i.e. drivers). The matching for devices and drivers is performed according to the IPMI standard for FRU devices (Field Replaceable Units). The code includes support for parsing an SDB tree if present in the F

Re: [PATCH 3/8] FMC: add core bus driver

2013-03-15 Thread Greg KH
On Thu, Feb 21, 2013 at 07:14:01PM +0100, Alessandro Rubini wrote: > -/* Every device must have a release method: provide a default */ > +/* We really have nothing to release in here */ > static void __fmc_release(struct device *dev) { } Then your implementation is wrong, and as per the documenta

[PATCH 3/8] FMC: add core bus driver

2013-02-21 Thread Alessandro Rubini
This module offers registration services for both carriers (i.e. devices) and mezzanines (i.e. drivers). The matching for devices and drivers is performed according to the IPMI standard for FRU devices (Field Replaceable Units). The code includes support for parsing an SDB tree if present in the F