Re: [PATCH 3/7] perf metricgroup: Delay events string creation

2020-05-20 Thread Jiri Olsa
On Wed, May 20, 2020 at 05:34:09PM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, May 20, 2020 at 11:22:22AM -0700, Ian Rogers escreveu: > > On Wed, May 20, 2020 at 6:14 AM Jiri Olsa wrote: > > > > break; > > > > } > > > > } > > > > + if (!re

Re: [PATCH 3/7] perf metricgroup: Delay events string creation

2020-05-20 Thread Arnaldo Carvalho de Melo
Em Wed, May 20, 2020 at 11:22:22AM -0700, Ian Rogers escreveu: > On Wed, May 20, 2020 at 6:14 AM Jiri Olsa wrote: > > > break; > > > } > > > } > > > + if (!ret) { > > > > could you please do instead: > > > > if (ret) > >

Re: [PATCH 3/7] perf metricgroup: Delay events string creation

2020-05-20 Thread Ian Rogers
On Wed, May 20, 2020 at 6:14 AM Jiri Olsa wrote: > > On Wed, May 20, 2020 at 12:28:10AM -0700, Ian Rogers wrote: > > Currently event groups are placed into groups_list at the same time as > > the events string containing the events is built. Separate these two > > operations and build the groups_l

Re: [PATCH 3/7] perf metricgroup: Delay events string creation

2020-05-20 Thread Jiri Olsa
On Wed, May 20, 2020 at 12:28:10AM -0700, Ian Rogers wrote: > Currently event groups are placed into groups_list at the same time as > the events string containing the events is built. Separate these two > operations and build the groups_list first, then the event string from > the groups_list. Thi

[PATCH 3/7] perf metricgroup: Delay events string creation

2020-05-20 Thread Ian Rogers
Currently event groups are placed into groups_list at the same time as the events string containing the events is built. Separate these two operations and build the groups_list first, then the event string from the groups_list. This adds an ability to reorder the groups_list that will be used in a