Re: [PATCH 3/7] locking/pvqspinlock: Implement wait-early for overcommitted guest

2015-07-14 Thread Waiman Long
On 07/13/2015 03:50 PM, Davidlohr Bueso wrote: On Sat, 2015-07-11 at 16:36 -0400, Waiman Long wrote: /* + * Queued Spinlock Spin Thresholds + * --- + * Because of the cacheline contention effect of the ticket spinlock, the + * same spin threshold for queued spinlock

Re: [PATCH 3/7] locking/pvqspinlock: Implement wait-early for overcommitted guest

2015-07-13 Thread Davidlohr Bueso
On Sat, 2015-07-11 at 16:36 -0400, Waiman Long wrote: > /* > + * Queued Spinlock Spin Thresholds > + * --- > + * Because of the cacheline contention effect of the ticket spinlock, the > + * same spin threshold for queued spinlock will run a bit faster. So we set > + * a

Re: [PATCH 3/7] locking/pvqspinlock: Implement wait-early for overcommitted guest

2015-07-12 Thread Peter Zijlstra
On Sat, Jul 11, 2015 at 04:36:54PM -0400, Waiman Long wrote: > In an overcommitted guest where some vCPUs have to be halted to make > forward progress in other areas, it is highly likely that a vCPU > later in the spinlock queue will be spinning while the ones earlier in > the queue would have been

[PATCH 3/7] locking/pvqspinlock: Implement wait-early for overcommitted guest

2015-07-11 Thread Waiman Long
In an overcommitted guest where some vCPUs have to be halted to make forward progress in other areas, it is highly likely that a vCPU later in the spinlock queue will be spinning while the ones earlier in the queue would have been halted already. The spinning in the later vCPUs is then just a waste