Re: [PATCH 3/6 v9] gpio: Add userland device interface to block GPIO

2012-12-05 Thread Wolfgang Grandegger
On 12/05/2012 11:20 PM, Roland Stigge wrote: > Hi Wolfgang, > > On 05/12/12 20:01, Wolfgang Grandegger wrote: >>> + for (i = 0; i < block->ngpio; i++) { >>> + status = gpio_request(block->gpio[i], "gpioblock dev"); >> >> You could use the name of the GPIO block. > > OK. > >>> +

Re: [PATCH 3/6 v9] gpio: Add userland device interface to block GPIO

2012-12-05 Thread Roland Stigge
Hi Wolfgang, On 05/12/12 20:01, Wolfgang Grandegger wrote: >> +for (i = 0; i < block->ngpio; i++) { >> +status = gpio_request(block->gpio[i], "gpioblock dev"); > > You could use the name of the GPIO block. OK. >> +if (status) >> +goto err1; >> + >

Re: [PATCH 3/6 v9] gpio: Add userland device interface to block GPIO

2012-12-05 Thread Wolfgang Grandegger
On 12/04/2012 09:39 PM, Roland Stigge wrote: > This patch adds a character device interface to the block GPIO system. > > Signed-off-by: Roland Stigge > --- > Documentation/ABI/testing/dev-gpioblock | 34 + > drivers/gpio/gpiolib.c | 208 > +++

[PATCH 3/6 v9] gpio: Add userland device interface to block GPIO

2012-12-04 Thread Roland Stigge
This patch adds a character device interface to the block GPIO system. Signed-off-by: Roland Stigge --- Documentation/ABI/testing/dev-gpioblock | 34 + drivers/gpio/gpiolib.c | 208 +++- include/linux/gpio.h| 10 + 3 files