[PATCH 3/6] x86/mbm: Intel Memory B/W Monitoring enumeration and init

2016-03-10 Thread Vikas Shivappa
The MBM init patch enumerates the Intel (Memory b/w monitoring)MBM and initializes the perf events and datastructures for monitoring the memory b/w. Its based on original patch series by Tony Luck and Kanaka Juvva. Memory bandwidth monitoring(MBM) provides OS/VMM a way to monitor bandwidth from on

Re: [PATCH 3/6] x86/mbm: Intel Memory B/W Monitoring enumeration and init

2016-03-08 Thread Vikas Shivappa
On Tue, 8 Mar 2016, Thomas Gleixner wrote: On Thu, 3 Mar 2016, Thomas Gleixner wrote: On Thu, 3 Mar 2016, Vikas Shivappa wrote: On Wed, 2 Mar 2016, Thomas Gleixner wrote: On Wed, 2 Mar 2016, Vikas Shivappa wrote: + if (cqm_enabled && mbm_enabled) + intel_cqm_events_

Re: [PATCH 3/6] x86/mbm: Intel Memory B/W Monitoring enumeration and init

2016-03-08 Thread Thomas Gleixner
On Thu, 3 Mar 2016, Thomas Gleixner wrote: > On Thu, 3 Mar 2016, Vikas Shivappa wrote: > > > > > > > On Wed, 2 Mar 2016, Thomas Gleixner wrote: > > > > > On Wed, 2 Mar 2016, Vikas Shivappa wrote: > > > > + if (cqm_enabled && mbm_enabled) > > > > + intel_cqm_events_group.attr

Re: [PATCH 3/6] x86/mbm: Intel Memory B/W Monitoring enumeration and init

2016-03-03 Thread Thomas Gleixner
On Thu, 3 Mar 2016, Vikas Shivappa wrote: > > > On Wed, 2 Mar 2016, Thomas Gleixner wrote: > > > On Wed, 2 Mar 2016, Vikas Shivappa wrote: > > > + if (cqm_enabled && mbm_enabled) > > > + intel_cqm_events_group.attrs = intel_cmt_mbm_events_attr; > > > + else if (!cqm_enabled && mbm_enabl

Re: [PATCH 3/6] x86/mbm: Intel Memory B/W Monitoring enumeration and init

2016-03-03 Thread Vikas Shivappa
On Wed, 2 Mar 2016, Thomas Gleixner wrote: On Wed, 2 Mar 2016, Vikas Shivappa wrote: + if (cqm_enabled && mbm_enabled) + intel_cqm_events_group.attrs = intel_cmt_mbm_events_attr; + else if (!cqm_enabled && mbm_enabled) + intel_cqm_events_group.attrs = i

Re: [PATCH 3/6] x86/mbm: Intel Memory B/W Monitoring enumeration and init

2016-03-02 Thread Thomas Gleixner
On Wed, 2 Mar 2016, Vikas Shivappa wrote: > + if (cqm_enabled && mbm_enabled) > + intel_cqm_events_group.attrs = intel_cmt_mbm_events_attr; > + else if (!cqm_enabled && mbm_enabled) > + intel_cqm_events_group.attrs = intel_mbm_events_attr; > + else if (cqm_enable

Re: [PATCH 3/6] x86/mbm: Intel Memory B/W Monitoring enumeration and init

2016-03-02 Thread Vikas Shivappa
The MBM init patch enumerates the Intel (Memory b/w monitoring)MBM and initializes the perf events and datastructures for monitoring the memory b/w. Its based on original patch series by Tony Luck and Kanaka Juvva. Memory bandwidth monitoring(MBM) provides OS/VMM a way to monitor bandwidth from on

Re: [PATCH 3/6] x86/mbm: Intel Memory B/W Monitoring enumeration and init

2016-03-02 Thread Vikas Shivappa
On Wed, 2 Mar 2016, Vikas Shivappa wrote: On Wed, 2 Mar 2016, Thomas Gleixner wrote: Leaks mbm_local and mbm_total Will fix. Thanks for pointing out. I missed the ones which are done at the next level of calls from the init. Will do a check on all the globals as well. Vikas Lo

Re: [PATCH 3/6] x86/mbm: Intel Memory B/W Monitoring enumeration and init

2016-03-02 Thread Vikas Shivappa
On Wed, 2 Mar 2016, Thomas Gleixner wrote: On Tue, 1 Mar 2016, Vikas Shivappa wrote: @@ -1397,8 +1543,11 @@ static int __init intel_cqm_init(void) __perf_cpu_notifier(intel_cqm_cpu_notifier); out: cpu_notifier_register_done(); - if (ret) + if (ret) { +

Re: [PATCH 3/6] x86/mbm: Intel Memory B/W Monitoring enumeration and init

2016-03-02 Thread Thomas Gleixner
On Tue, 1 Mar 2016, Vikas Shivappa wrote: > @@ -1397,8 +1543,11 @@ static int __init intel_cqm_init(void) > __perf_cpu_notifier(intel_cqm_cpu_notifier); > out: > cpu_notifier_register_done(); > - if (ret) > + if (ret) { > + mbm_enabled = false; > + cqm_e

[PATCH 3/6] x86/mbm: Intel Memory B/W Monitoring enumeration and init

2016-03-01 Thread Vikas Shivappa
The MBM init patch enumerates the Intel (Memory b/w monitoring)MBM and initializes the perf events and datastructures for monitoring the memory b/w. Its based on original patch series by Tony Luck and Kanaka Juvva. Memory bandwidth monitoring(MBM) provides OS/VMM a way to monitor bandwidth from on