Re: [PATCH 3/6] clk: mstar: MStar/SigmaStar MPLL driver

2020-12-21 Thread Daniel Palmer
Hi Stephen, On Mon, 21 Dec 2020 at 03:43, Stephen Boyd wrote: > Can be part of the same series. Ok. I have added a small patch that adds devm_clk_hw_register_fixed_factor(). I'll send that in the v2 once the clock names issue is resolved. Thanks, Daniel

Re: [PATCH 3/6] clk: mstar: MStar/SigmaStar MPLL driver

2020-12-20 Thread Stephen Boyd
Quoting Daniel Palmer (2020-12-19 22:42:40) > > > + > > > +static int msc313_mpll_remove(struct platform_device *pdev) > > > +{ > > > + struct msc313_mpll *mpll = platform_get_drvdata(pdev); > > > + int i; > > > + > > > + for (i = 0; i < ARRAY_SIZE(output_dividers); i++) > > > +

Re: [PATCH 3/6] clk: mstar: MStar/SigmaStar MPLL driver

2020-12-19 Thread Daniel Palmer
Hi Stephen, On Sun, 20 Dec 2020 at 13:36, Stephen Boyd wrote: > > diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile > > index da8fcf147eb1..b758aae17ab8 100644 > > --- a/drivers/clk/Makefile > > +++ b/drivers/clk/Makefile > > @@ -124,3 +124,4 @@ endif > > obj-$(CONFIG_ARCH_ZX)

Re: [PATCH 3/6] clk: mstar: MStar/SigmaStar MPLL driver

2020-12-19 Thread Stephen Boyd
Quoting Daniel Palmer (2020-11-14 05:50:41) > F: include/dt-bindings/gpio/msc313-gpio.h > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig > index c715d4681a0b..a002f2605fa3 100644 > --- a/drivers/clk/Kconfig > +++ b/drivers/clk/Kconfig > @@ -370,6 +370,7 @@ source "drivers/clk/ingenic/K

[PATCH 3/6] clk: mstar: MStar/SigmaStar MPLL driver

2020-11-14 Thread Daniel Palmer
This adds a basic driver for the MPLL block found in MStar/SigmaStar ARMv7 SoCs. Currently this driver is only good for calculating the rates of it's outputs and the actual configuration must be done before the kernel boots. Usually this is done even before u-boot starts. This driver targets the