Re: [PATCH 3/6] ASoC: ux500: Drop pinctrl sleep support

2013-05-17 Thread Linus Walleij
On Wed, May 8, 2013 at 5:48 PM, Fabio Baltieri wrote: > On Wed, May 08, 2013 at 03:29:38PM +0100, Mark Brown wrote: >> It seems like the code is definitely buggy here but is this really all >> that's buggy or is it just the symptom you happen to have seen? > > For the pinctrl code drop I still th

Re: [PATCH 3/6] ASoC: ux500: Drop pinctrl sleep support

2013-05-13 Thread Fabio Baltieri
On Thu, May 09, 2013 at 10:41:03AM +0100, Mark Brown wrote: > On Wed, May 08, 2013 at 05:48:05PM +0200, Fabio Baltieri wrote: > > On Wed, May 08, 2013 at 03:29:38PM +0100, Mark Brown wrote: > > > > So if these pins are being shared between the instances then surely > > > there are other interdepen

Re: [PATCH 3/6] ASoC: ux500: Drop pinctrl sleep support

2013-05-09 Thread Mark Brown
On Wed, May 08, 2013 at 05:48:05PM +0200, Fabio Baltieri wrote: > On Wed, May 08, 2013 at 03:29:38PM +0100, Mark Brown wrote: > > So if these pins are being shared between the instances then surely > > there are other interdependencies that need to be taken care of Is that > > happening? For exam

Re: [PATCH 3/6] ASoC: ux500: Drop pinctrl sleep support

2013-05-09 Thread Mark Brown
On Wed, May 08, 2013 at 04:07:29PM +0100, Lee Jones wrote: > Why don't we wait and see what LinusW says? > If anyone would know, it's him. This stuff is all kind of off the point now... signature.asc Description: Digital signature

Re: [PATCH 3/6] ASoC: ux500: Drop pinctrl sleep support

2013-05-08 Thread Fabio Baltieri
On Wed, May 08, 2013 at 03:29:38PM +0100, Mark Brown wrote: > On Wed, May 08, 2013 at 04:17:23PM +0200, Fabio Baltieri wrote: > > On Wed, May 08, 2013 at 02:54:13PM +0100, Mark Brown wrote: > > > > But why does the rest of the code work well if the reference counting is > > > wrong, it's in the mi

Re: [PATCH 3/6] ASoC: ux500: Drop pinctrl sleep support

2013-05-08 Thread Lee Jones
On Wed, 08 May 2013, Mark Brown wrote: > On Wed, May 08, 2013 at 04:27:34PM +0200, Fabio Baltieri wrote: > > On Wed, May 08, 2013 at 04:17:23PM +0200, Fabio Baltieri wrote: > > > > Ok, what I'm trying to say is that the codec used in this platform > > > should be able to handle sleep modes withou

Re: [PATCH 3/6] ASoC: ux500: Drop pinctrl sleep support

2013-05-08 Thread Mark Brown
On Wed, May 08, 2013 at 04:27:34PM +0200, Fabio Baltieri wrote: > On Wed, May 08, 2013 at 04:17:23PM +0200, Fabio Baltieri wrote: > > Ok, what I'm trying to say is that the codec used in this platform > > should be able to handle sleep modes without requiring any > > reconfiguration of the digital

Re: [PATCH 3/6] ASoC: ux500: Drop pinctrl sleep support

2013-05-08 Thread Mark Brown
On Wed, May 08, 2013 at 04:17:23PM +0200, Fabio Baltieri wrote: > On Wed, May 08, 2013 at 02:54:13PM +0100, Mark Brown wrote: > > But why does the rest of the code work well if the reference counting is > > wrong, it's in the middle of a big block of code? This all smells like > > this change is

Re: [PATCH 3/6] ASoC: ux500: Drop pinctrl sleep support

2013-05-08 Thread Fabio Baltieri
On Wed, May 08, 2013 at 04:17:23PM +0200, Fabio Baltieri wrote: > > > If I understood the problem correctly you do that when you want to cut > > > power completely to some peripherals to avoid spurious current paths, > > > and that should not be the case for the audio codec, especially in this > >

Re: [PATCH 3/6] ASoC: ux500: Drop pinctrl sleep support

2013-05-08 Thread Fabio Baltieri
On Wed, May 08, 2013 at 02:54:13PM +0100, Mark Brown wrote: > On Wed, May 08, 2013 at 03:10:20PM +0200, Fabio Baltieri wrote: > > On Wed, May 08, 2013 at 01:32:25PM +0100, Mark Brown wrote: > > > > I'm saying that if functions like enable_msp() don't work reliably then > > > removing some but not

Re: [PATCH 3/6] ASoC: ux500: Drop pinctrl sleep support

2013-05-08 Thread Mark Brown
On Wed, May 08, 2013 at 03:10:20PM +0200, Fabio Baltieri wrote: > On Wed, May 08, 2013 at 01:32:25PM +0100, Mark Brown wrote: > > I'm saying that if functions like enable_msp() don't work reliably then > > removing some but not all of their functionality isn't an obviously good > > approach to fix

Re: [PATCH 3/6] ASoC: ux500: Drop pinctrl sleep support

2013-05-08 Thread Fabio Baltieri
On Wed, May 08, 2013 at 01:32:25PM +0100, Mark Brown wrote: > On Wed, May 08, 2013 at 01:42:16PM +0200, Fabio Baltieri wrote: > > On Wed, May 08, 2013 at 11:51:24AM +0100, Mark Brown wrote: > > > > I tend to agree with Lee that this looks like a bad approach - there's a > > > whole bunch of other

Re: [PATCH 3/6] ASoC: ux500: Drop pinctrl sleep support

2013-05-08 Thread Mark Brown
On Wed, May 08, 2013 at 01:42:16PM +0200, Fabio Baltieri wrote: > On Wed, May 08, 2013 at 11:51:24AM +0100, Mark Brown wrote: > > I tend to agree with Lee that this looks like a bad approach - there's a > > whole bunch of other code in there which I'd guess is probably equally > > broken but only

Re: [PATCH 3/6] ASoC: ux500: Drop pinctrl sleep support

2013-05-08 Thread Fabio Baltieri
On Wed, May 08, 2013 at 11:51:24AM +0100, Mark Brown wrote: > On Wed, May 08, 2013 at 09:14:18AM +0200, Fabio Baltieri wrote: > > Drop pinctrl default/sleep state switching code, as it was breaking the > > capture interface by putting the I2S pins in hi-z mode regardless of its > > usage status, an

Re: [PATCH 3/6] ASoC: ux500: Drop pinctrl sleep support

2013-05-08 Thread Mark Brown
On Wed, May 08, 2013 at 09:14:18AM +0200, Fabio Baltieri wrote: > Drop pinctrl default/sleep state switching code, as it was breaking the > capture interface by putting the I2S pins in hi-z mode regardless of its > usage status, and not giving any real benefit. > > Pinctrl default mode configurati

Re: [PATCH 3/6] ASoC: ux500: Drop pinctrl sleep support

2013-05-08 Thread Fabio Baltieri
On Wed, May 08, 2013 at 09:48:46AM +0100, Lee Jones wrote: > On Wed, 08 May 2013, Fabio Baltieri wrote: > > > On Wed, May 08, 2013 at 09:07:08AM +0100, Lee Jones wrote: > > > On Wed, 08 May 2013, Fabio Baltieri wrote: > > > > > > > Drop pinctrl default/sleep state switching code, as it was breaki

Re: [PATCH 3/6] ASoC: ux500: Drop pinctrl sleep support

2013-05-08 Thread Lee Jones
On Wed, 08 May 2013, Fabio Baltieri wrote: > On Wed, May 08, 2013 at 09:07:08AM +0100, Lee Jones wrote: > > On Wed, 08 May 2013, Fabio Baltieri wrote: > > > > > Drop pinctrl default/sleep state switching code, as it was breaking the > > > capture interface by putting the I2S pins in hi-z mode reg

Re: [PATCH 3/6] ASoC: ux500: Drop pinctrl sleep support

2013-05-08 Thread Fabio Baltieri
On Wed, May 08, 2013 at 09:07:08AM +0100, Lee Jones wrote: > On Wed, 08 May 2013, Fabio Baltieri wrote: > > > Drop pinctrl default/sleep state switching code, as it was breaking the > > capture interface by putting the I2S pins in hi-z mode regardless of its > > usage status, and not giving any re

Re: [PATCH 3/6] ASoC: ux500: Drop pinctrl sleep support

2013-05-08 Thread Lee Jones
On Wed, 08 May 2013, Fabio Baltieri wrote: > Drop pinctrl default/sleep state switching code, as it was breaking the > capture interface by putting the I2S pins in hi-z mode regardless of its > usage status, and not giving any real benefit. > > Pinctrl default mode configuration is already manage

[PATCH 3/6] ASoC: ux500: Drop pinctrl sleep support

2013-05-08 Thread Fabio Baltieri
Drop pinctrl default/sleep state switching code, as it was breaking the capture interface by putting the I2S pins in hi-z mode regardless of its usage status, and not giving any real benefit. Pinctrl default mode configuration is already managed automatically by a specific pinctrl hog. Signed-off